From patchwork Mon Jan 14 19:55:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 211879 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C8C132C00A6 for ; Tue, 15 Jan 2013 07:00:45 +1100 (EST) Received: from localhost ([::1]:53539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuqD5-0001PA-Tu for incoming@patchwork.ozlabs.org; Mon, 14 Jan 2013 15:00:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuqCk-0001GU-A7 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuqCf-0008OS-Qd for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:22 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:52175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuqCf-0008Nu-D4 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 15:00:17 -0500 Received: by mail-ie0-f171.google.com with SMTP id 17so5720652iea.2 for ; Mon, 14 Jan 2013 12:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=a4NJnb9ygWfaIn2nA+pdxGEcD7D0kn529ueekCSZKhE=; b=fyU8uIdcEzmqEHfA8LxQEApx1gGiWe654Y13s7qW8bh8vgY1InwWsRLpS7E+naZXWl tTfFFnaKbu4Si95O4uCa61de1yriS5acJHdj1ECn8QnLaCh9tIG9Mesg273XbBiQhSlo /fTwHrqAEZE9BtSnpUnOZx+pnMSgThvk8Le2W+F7uwevQUhU2+MziNiOqId8ruhia682 c1/YN1sdzcOBvCStEN2EP6NXcUrAFwBm7qUxL8hW+5I+3ngHJbH77XQrBTV6XOJQpECq tQkjzkXDoFRFuZxktdVcYkQx1R2KOWnvBmtbdHWgHLJnagbiZk6xwXXc4dtHuVIWgUDg sJGQ== X-Received: by 10.50.184.164 with SMTP id ev4mr3187674igc.91.1358193616045; Mon, 14 Jan 2013 12:00:16 -0800 (PST) Received: from localhost ([32.97.110.59]) by mx.google.com with ESMTPS id nj1sm146308igc.3.2013.01.14.12.00.15 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 14 Jan 2013 12:00:15 -0800 (PST) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 14 Jan 2013 13:55:07 -0600 Message-Id: <1358193312-15960-4-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1358193312-15960-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1358193312-15960-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.223.171 Cc: aliguori@us.ibm.com, armbru@redhat.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 3/8] qemu-ga: Document intentional fall through in channel_event_cb() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Michael Roth Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/main.c b/qga/main.c index bd70ead..e8a9a9e 100644 --- a/qga/main.c +++ b/qga/main.c @@ -618,6 +618,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data) if (!s->virtio) { return false; } + /* fall through */ case G_IO_STATUS_AGAIN: /* virtio causes us to spin here when no process is attached to * host-side chardev. sleep a bit to mitigate this