From patchwork Thu Jan 10 14:41:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 211024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 400E92C0327 for ; Fri, 11 Jan 2013 01:41:36 +1100 (EST) Received: from localhost ([::1]:54892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJK2-0005nG-Bg for incoming@patchwork.ozlabs.org; Thu, 10 Jan 2013 09:41:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJJu-0005n0-G8 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:41:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtJJr-0004q7-Vx for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:41:25 -0500 Received: from mail-vb0-f50.google.com ([209.85.212.50]:35919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJJr-0004pw-R7 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:41:23 -0500 Received: by mail-vb0-f50.google.com with SMTP id ft2so473224vbb.9 for ; Thu, 10 Jan 2013 06:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer; bh=qYD3zLDbTquR1SDlB3RfG6YXUhFeFZMiWcVaqWSY7kE=; b=GPoeLsQij/SeVFFYro8p/8sYIl0D+UtzaQy2RarGNa20xhIsfhDjY/X5FwELrQWv+1 IuFDklvYHnX9wzmSKLv8x67aBGc5OdkTT/a1HeMH6s4+uZn/4PudbO9McQInoKWDKsFf zAwk4hE9A0utQ8on2KADY5sfte37GR0/kkAxbTROyWjkGxfAFgfpXTaPatiVWPYLM+U7 eb9/fi9pQsmDrFtNU0FqX5ZCOm+HiTBzBrNA98/d9m8Mzv6Bf54Fh9tmZBSY3r0h6T+h GwMkdpKfxP+z3XmnfmGDXJ2KnLzxudOv+2I8v1Lghzc0+huCzhSrPfePOMNh783jmfrr v8xg== X-Received: by 10.52.97.7 with SMTP id dw7mr79783459vdb.38.1357828883244; Thu, 10 Jan 2013 06:41:23 -0800 (PST) Received: from yakj.usersys.redhat.com (93-34-179-137.ip50.fastwebnet.it. [93.34.179.137]) by mx.google.com with ESMTPS id dx4sm473478vdb.16.2013.01.10.06.41.21 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 10 Jan 2013 06:41:22 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 10 Jan 2013 15:41:15 +0100 Message-Id: <1357828875-2484-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.212.50 Cc: kraxel@redhat.com Subject: [Qemu-devel] [PATCH] intel-hda: do not reset codecs from intel_hda_reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org They are reset implicitly by walking the qdev tree, before calling intel_hda_reset. Signed-off-by: Paolo Bonzini --- hw/intel-hda.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 98ff936..850e60f 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -1112,7 +1112,6 @@ static void intel_hda_reset(DeviceState *dev) QTAILQ_FOREACH(kid, &d->codecs.qbus.children, sibling) { DeviceState *qdev = kid->child; cdev = DO_UPCAST(HDACodecDevice, qdev, qdev); - device_reset(DEVICE(cdev)); d->state_sts |= (1 << cdev->cad); } intel_hda_update_irq(d);