From patchwork Mon Dec 10 06:59:46 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Spencer X-Patchwork-Id: 204825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E4DB92C023D for ; Mon, 10 Dec 2012 18:01:09 +1100 (EST) Received: from localhost ([::1]:56046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThxMR-0000YA-Tv for incoming@patchwork.ozlabs.org; Mon, 10 Dec 2012 02:01:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThxME-0000Nf-NR for qemu-devel@nongnu.org; Mon, 10 Dec 2012 02:00:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThxMB-0005SE-D0 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 02:00:54 -0500 Received: from furnace.wzff.de ([2a01:4f8:150:63e2::9]:22427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThxM5-0005Q8-08; Mon, 10 Dec 2012 02:00:45 -0500 Received: from xdsl-188-155-204-150.adslplus.ch ([188.155.204.150] helo=localhost.localdomain) by furnace.wzff.de with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1ThxM2-000KiM-SI; Mon, 10 Dec 2012 08:00:44 +0100 From: John Spencer To: qemu-trivial@nongnu.org Date: Mon, 10 Dec 2012 07:59:46 +0100 Message-Id: <1355122786-29243-4-git-send-email-maillist-qemu@barfooze.de> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> References: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:150:63e2::9 Cc: qemu-devel@nongnu.org, John Spencer Subject: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header. Signed-off-by: John Spencer Reviewed-by: Stefan Weil --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fabbcd7..665316e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -585,7 +586,6 @@ extern int personality(int); extern int flock(int, int); extern int setfsuid(int); extern int setfsgid(int); -extern int setgroups(int, gid_t *); /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM