From patchwork Wed Nov 28 15:30:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 202480 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7DEC72C0085 for ; Thu, 29 Nov 2012 02:30:43 +1100 (EST) Received: from localhost ([::1]:40697 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdjaz-0004hn-BC for incoming@patchwork.ozlabs.org; Wed, 28 Nov 2012 10:30:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdjak-0004h9-CV for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tdjai-0003Kx-Hl for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:30:26 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdjai-0003KA-7F for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:30:24 -0500 Received: by mail-pa0-f45.google.com with SMTP id bg2so6916653pad.4 for ; Wed, 28 Nov 2012 07:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=M/pRjiYLmLYumweIb/0mfq4bbIANGX59nuTdYT4yunw=; b=cYymlK0jOhfVYDqzbv/8w1PxUmi4GlW4VP/4UDGJT8PT1EZRRnEM/WHHi+RwKNPr3/ 8+IYmoGz4zwCmb4QADv+bh08iVXqyus0mWmWZLi0YpxSP4rZGnIx99L+BAZ5QL32wM3Q FMuUAPrqo4f0ydyoPCCysiH1dxxiLRAGMaxOu7W8y3VrBNRFTRLNMmzsJbSZXUhv5tHa DZiniMHLrGd58rScUT85ZBEIi54cW6rBBErBW+Y+HG96GRd3tR9JlAcXPB74WNutdt+Z MI/X5nEUuPDE8ISR/R4MgzdcY+S5H0OLPPyjUEQARFBR+GDjzlrkktiDYVH5a+WXTIg6 9AQw== Received: by 10.68.216.73 with SMTP id oo9mr58996050pbc.80.1354116623176; Wed, 28 Nov 2012 07:30:23 -0800 (PST) Received: from yakj.usersys.redhat.com (93-34-169-1.ip50.fastwebnet.it. [93.34.169.1]) by mx.google.com with ESMTPS id nf9sm12606734pbc.17.2012.11.28.07.30.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Nov 2012 07:30:22 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 28 Nov 2012 16:30:03 +0100 Message-Id: <1354116604-32298-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1354116604-32298-1-git-send-email-pbonzini@redhat.com> References: <1354116604-32298-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.45 Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [PATCH 1/2] nbd: fix use of two uninitialized bytes when connecting to a named export X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reported-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index 97a5914..01976e8 100644 --- a/nbd.c +++ b/nbd.c @@ -397,6 +397,7 @@ static int nbd_send_negotiate(NBDClient *client) rc = -EINVAL; TRACE("Beginning negotiation."); + memset(buf, 0, sizeof(buf)); memcpy(buf, "NBDMAGIC", 8); if (client->exp) { assert ((client->exp->nbdflags & ~65535) == 0); @@ -406,7 +407,6 @@ static int nbd_send_negotiate(NBDClient *client) } else { cpu_to_be64w((uint64_t*)(buf + 8), NBD_OPTS_MAGIC); } - memset(buf + 28, 0, 124); if (client->exp) { if (write_sync(csock, buf, sizeof(buf)) != sizeof(buf)) {