From patchwork Fri Oct 19 09:08:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 192621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 751A02C007D for ; Fri, 19 Oct 2012 20:08:25 +1100 (EST) Received: from localhost ([::1]:59470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP8Z5-0007ze-Dr for incoming@patchwork.ozlabs.org; Fri, 19 Oct 2012 05:08:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP8Ys-0007tZ-4n for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:08:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TP8Yq-0004aJ-Hn for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:08:10 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:48623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TP8Yq-0004aB-BJ for qemu-devel@nongnu.org; Fri, 19 Oct 2012 05:08:08 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so290929pbb.4 for ; Fri, 19 Oct 2012 02:08:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=BDYHOWWsWoQISDVLvwnEWmm0IZQmAuXUN0O9JbInGg8=; b=Q6WlikrmY9ltiACF9/VD9b+ZzFyK3ovvvuvPwlnWC4IAri77ZvsofffOUdv7O42IGY aAHXeUI/IZnYKLyv1QLq1ubssv3N8/+e37d4dHarTwHk3SjUaSjB9qk4X3MVAt/rPFUr 758E2gSLxzYWhPIR97YhIob4f5kHx48HmKkLN0tFsR0sZ4WNccBgGx5C1oJ9RvO51Vq1 2wiW8RtVT7K1CRA6DRLHrPgs00qxI1JW2DkYPSNTIPlpepm35FPh8R8GhXxumcd50i9z wRwujtDYA0Zozllayb2k30AveCY+LbnspWFvuaBeMybacPnl7mCL20MfsQoezd7y/kT8 f4cw== Received: by 10.66.85.66 with SMTP id f2mr1882536paz.56.1350637687683; Fri, 19 Oct 2012 02:08:07 -0700 (PDT) Received: from localhost ([124.148.20.9]) by mx.google.com with ESMTPS id k9sm790951paz.22.2012.10.19.02.08.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 02:08:07 -0700 (PDT) From: Peter Crosthwaite To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Date: Fri, 19 Oct 2012 19:08:04 +1000 Message-Id: <1350637684-32300-1-git-send-email-peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.7.0.4 X-Gm-Message-State: ALoCoQnej9xLwsXS9DBzoeuSst0Jmc1v/aQ5U6kMTaKN4Ol1nblykrNlw6JiAdUeWxxnPhQCNkUR X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Cc: Peter Crosthwaite Subject: [Qemu-devel] [PATCH] cadence_uart: More debug information X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add more helpful debug information to the cadence UART. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/cadence_uart.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c index f8afc4e..483a316 100644 --- a/hw/cadence_uart.c +++ b/hw/cadence_uart.c @@ -359,7 +359,7 @@ static void uart_write(void *opaque, target_phys_addr_t offset, { UartState *s = (UartState *)opaque; - DB_PRINT(" offset:%x data:%08x\n", offset, (unsigned)value); + DB_PRINT(" offset:%x data:%08x\n", (unsigned)offset, (unsigned)value); offset >>= 2; switch (offset) { case R_IER: /* ier (wts imr) */ @@ -405,12 +405,15 @@ static uint64_t uart_read(void *opaque, target_phys_addr_t offset, offset >>= 2; if (offset >= R_MAX) { - return 0; + c = 0; } else if (offset == R_TX_RX) { uart_read_rx_fifo(s, &c); - return c; + } else { + c = s->r[offset]; } - return s->r[offset]; + + DB_PRINT(" offset:%x data:%08x\n", (unsigned)(offset << 2), (unsigned)c); + return c; } static const MemoryRegionOps uart_ops = {