From patchwork Mon Oct 8 07:51:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 189944 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 154F62C0223 for ; Mon, 8 Oct 2012 19:30:39 +1100 (EST) Received: from localhost ([::1]:50460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TL87f-0004Yx-9Z for incoming@patchwork.ozlabs.org; Mon, 08 Oct 2012 03:51:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TL86T-0001b0-Qj for qemu-devel@nongnu.org; Mon, 08 Oct 2012 03:50:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TL86P-00069R-CC for qemu-devel@nongnu.org; Mon, 08 Oct 2012 03:50:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TL86O-00066X-Pv for qemu-devel@nongnu.org; Mon, 08 Oct 2012 03:50:13 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q987oC9U001522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Oct 2012 03:50:12 -0400 Received: from shalem.localdomain.com (vpn1-7-79.ams2.redhat.com [10.36.7.79]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q987o59f012329; Mon, 8 Oct 2012 03:50:11 -0400 From: Hans de Goede To: Gerd Hoffmann Date: Mon, 8 Oct 2012 09:51:27 +0200 Message-Id: <1349682696-3046-4-git-send-email-hdegoede@redhat.com> In-Reply-To: <1349682696-3046-1-git-send-email-hdegoede@redhat.com> References: <1349682696-3046-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 03/12] usb-host-linux: Only enabling pipeling for output endpoints X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org With the upcoming input pipelining support, large input packets may get submitted to the device, which require special handling when the packets ends up being split again by usb-host-linux due to usbfs limitations. The exact demands for properly handling larger split input transfers is explained in detail in this libusb commit: https://github.com/libusbx/libusbx/commit/ede02ba91920f9be787a7f3cd006c5a4b92b5eab Specifically in the large comment block the commit adds. Note that IMHO it would be better to just port usb-host-linux to libusb and let libusb worry about such usbfs details, rather then reproducing all this code inside host-linux.c Note that the not proper handling of this currently already can be a problem when used in combination with an emulated xhci controller, as that can already submit large enough transfers to trigger this. Signed-off-by: Hans de Goede --- hw/usb/host-linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index 44f1a64..3a258b4 100644 --- a/hw/usb/host-linux.c +++ b/hw/usb/host-linux.c @@ -1224,7 +1224,8 @@ static int usb_linux_update_endp_table(USBHostDevice *s) usb_ep_set_type(&s->dev, pid, ep, type); usb_ep_set_ifnum(&s->dev, pid, ep, interface); if ((s->options & (1 << USB_HOST_OPT_PIPELINE)) && - (type == USB_ENDPOINT_XFER_BULK)) { + (type == USB_ENDPOINT_XFER_BULK) && + (pid == USB_TOKEN_OUT)) { usb_ep_set_pipeline(&s->dev, pid, ep, true); }