From patchwork Thu Sep 27 17:19:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 187419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1F6882C007F for ; Fri, 28 Sep 2012 03:26:25 +1000 (EST) Received: from localhost ([::1]:46632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THHqx-000744-4u for incoming@patchwork.ozlabs.org; Thu, 27 Sep 2012 13:26:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THHql-0006vl-UT for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THHqk-0005Yl-Pl for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:11 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:39647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THHqk-0004ys-HX for qemu-devel@nongnu.org; Thu, 27 Sep 2012 13:26:10 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so3912471pbb.4 for ; Thu, 27 Sep 2012 10:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=XRHNZEP+l85q491hpSuyf9gx/sW1Lo7gYNNmhxaZQy8=; b=O39nW6htNAGIFDEDVXr/a5YoXgslXCpnG8PwiSuORVwXfZK7lrC60423VNs1GE8HGQ qvj7ZC//YIx3pWrlAQjWUJBlb9+AeZ1++Og7LUMWRioXVueKmw4QGSWnefEgGlOWO7K6 OzllZMLz/BtlmeaOZ2b78UySNKhA7lxyJx/8aTkF91qt/Lozpx/7mCrp02S8skVSdksA 5OoOF3JFLL6yupSvIBTJ2qWZiT2bCqjvz9IiWqEq4CxZAu5Y6GzfP7Zp2mS1J1EFVsGr 5aou2upKDY32OJszScdPouTUA4DBM+J22cNX7dAE7dvqBQROWMiL0frzXmMTFW1lZQl6 7kyA== Received: by 10.68.129.5 with SMTP id ns5mr13186466pbb.103.1348766413354; Thu, 27 Sep 2012 10:20:13 -0700 (PDT) Received: from anchor.twiddle.home.com ([173.160.232.49]) by mx.google.com with ESMTPS id jw14sm4118581pbb.36.2012.09.27.10.20.12 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Sep 2012 10:20:12 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 27 Sep 2012 10:19:56 -0700 Message-Id: <1348766397-20731-7-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1348766397-20731-1-git-send-email-rth@twiddle.net> References: <1348766397-20731-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.160.45 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH 6/7] tcg: Tidy brcond optimization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Do the memset once. Don't reset_temp before doing so. Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno --- tcg/optimize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c1881fa..dfac877 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -771,22 +771,22 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, tmp = do_constant_folding_cond(op, args[0], args[1], args[2]); if (tmp != 2) { if (tmp) { - memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); gen_opc_buf[op_index] = INDEX_op_br; gen_args[0] = args[3]; gen_args += 1; } else { gen_opc_buf[op_index] = INDEX_op_nop; + args += 4; + break; } } else { - memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); - reset_temp(args[0]); gen_args[0] = args[0]; gen_args[1] = args[1]; gen_args[2] = args[2]; gen_args[3] = args[3]; gen_args += 4; } + memset(temps, 0, nb_temps * sizeof(struct tcg_temp_info)); args += 4; break; CASE_OP_32_64(movcond):