From patchwork Thu Aug 23 21:02:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 179723 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6C2AB2C00B0 for ; Fri, 24 Aug 2012 07:02:22 +1000 (EST) Received: from localhost ([::1]:40571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4eXk-0006PY-6J for incoming@patchwork.ozlabs.org; Thu, 23 Aug 2012 17:02:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4eXd-0006PF-98 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4eXW-0000J9-RA for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:13 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4eXW-0000J0-KM for qemu-devel@nongnu.org; Thu, 23 Aug 2012 17:02:06 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 415677280028; Thu, 23 Aug 2012 23:02:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id odPyArMhKB+2; Thu, 23 Aug 2012 23:02:03 +0200 (CEST) Received: by v220110690675601.yourvserver.net (Postfix, from userid 1000) id C0BC1728002A; Thu, 23 Aug 2012 23:02:03 +0200 (CEST) From: Stefan Weil To: qemu-devel@nongnu.org Date: Thu, 23 Aug 2012 23:02:02 +0200 Message-Id: <1345755722-25229-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 78.47.199.172 Cc: Stefan Weil , Hannes Reinecke Subject: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Type casts from pointer to integer values must use uintptr_t instead of unsigned long. Otherwise the compiler complains on hosts with sizeof(pointer) != sizeof(long). The patch also replace magic number 32 by sizeof(info.serial_number) which has the same value but is better for code reviews. Signed-off-by: Stefan Weil Acked-by: Hannes Reinecke --- hw/megasas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index c35a15d..f2d6783 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -698,8 +698,8 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd) } memcpy(info.product_name, "MegaRAID SAS 8708EM2", 20); - snprintf(info.serial_number, 32, "QEMU%08lx", - (unsigned long)s & 0xFFFFFFFF); + snprintf(info.serial_number, sizeof(info.serial_number), + "QEMU%08" PRIxPTR, (uintptr_t)s & 0xFFFFFFFF); snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION); memcpy(info.image_component[0].name, "APP", 3); memcpy(info.image_component[0].version, MEGASAS_VERSION "-QEMU", 9);