From patchwork Tue Aug 21 10:16:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 179030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 70BA02C0099 for ; Tue, 21 Aug 2012 20:39:42 +1000 (EST) Received: from localhost ([::1]:40738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lWw-0005UH-E2 for incoming@patchwork.ozlabs.org; Tue, 21 Aug 2012 06:17:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lWY-0004yq-4l for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3lWS-0008Vl-Dr for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lWS-0008Vh-5w for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:17:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7LAHICH002325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 Aug 2012 06:17:19 -0400 Received: from garlic.redhat.com (vpn-245-53.nrt.redhat.com [10.64.245.53]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7LAH7rc002769; Tue, 21 Aug 2012 06:17:15 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com, blauwirbel@gmail.com Date: Tue, 21 Aug 2012 13:16:21 +0300 Message-Id: <1345544183-19192-2-git-send-email-alevy@redhat.com> In-Reply-To: <1345544183-19192-1-git-send-email-alevy@redhat.com> References: <1345544183-19192-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v10 2/4] qxl: disallow unknown revisions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Alon Levy --- hw/qxl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break; case 3: /* qxl-3 */ - default: pci_device_rev = QXL_DEFAULT_REVISION; io_size = msb_mask(QXL_IO_RANGE_SIZE * 2 - 1); break; + default: + error_report("Invalid revision %d for qxl device (max %d)", + qxl->revision, QXL_DEFAULT_REVISION); + return -1; } pci_set_byte(&config[PCI_REVISION_ID], pci_device_rev);