| Message ID | 1343396239-19272-3-git-send-email-aliguori@us.ibm.com |
|---|---|
| State | New |
| Headers | show |
On Fri, 27 Jul 2012 08:37:14 -0500 Anthony Liguori <aliguori@us.ibm.com> wrote: > We've had a cycle to tweak. It is time to commit to supporting them. qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't we convert it to the qapi? > > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > --- > qapi-schema.json | 19 ++++--------------- > 1 files changed, 4 insertions(+), 15 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 015a84a..28e9914 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1360,9 +1360,7 @@ > # 4) A link type in the form 'link<subtype>' where subtype is a qdev > # device type name. Link properties form the device model graph. > # > -# Since: 1.1 > -# > -# Notes: This type is experimental. Its syntax may change in future releases. > +# Since: 1.2 > ## > { 'type': 'ObjectPropertyInfo', > 'data': { 'name': 'str', 'type': 'str' } } > @@ -1379,10 +1377,7 @@ > # Returns: a list of @ObjectPropertyInfo that describe the properties of the > # object. > # > -# Since: 1.1 > -# > -# Notes: This command is experimental. It's syntax may change in future > -# releases. > +# Since: 1.2 > ## > { 'command': 'qom-list', > 'data': { 'path': 'str' }, > @@ -1418,9 +1413,7 @@ > # returns as #str pathnames. All integer property types (u8, u16, etc) > # are returned as #int. > # > -# Since: 1.1 > -# > -# Notes: This command is experimental and may change syntax in future releases. > +# Since: 1.2 > ## > { 'command': 'qom-get', > 'data': { 'path': 'str', 'property': 'str' }, > @@ -1439,9 +1432,7 @@ > # @value: a value who's type is appropriate for the property type. See @qom-get > # for a description of type mapping. > # > -# Since: 1.1 > -# > -# Notes: This command is experimental and may change syntax in future releases. > +# Since: 1.2 > ## > { 'command': 'qom-set', > 'data': { 'path': 'str', 'property': 'str', 'value': 'visitor' }, > @@ -1719,8 +1710,6 @@ > # Returns: a list of @ObjectTypeInfo or an empty list if no results are found > # > # Since: 1.1 > -# > -# Notes: This command is experimental and may change syntax in future releases. > ## > { 'command': 'qom-list-types', > 'data': { '*implements': 'str', '*abstract': 'bool' },
Luiz Capitulino <lcapitulino@redhat.com> writes: > On Fri, 27 Jul 2012 08:37:14 -0500 > Anthony Liguori <aliguori@us.ibm.com> wrote: > >> We've had a cycle to tweak. It is time to commit to supporting them. > > qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't > we convert it to the qapi? qapi doesn't have a concept of type passthrough yet. If it was added, it could be converted. Regards, Anthony Liguori > >> >> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> >> --- >> qapi-schema.json | 19 ++++--------------- >> 1 files changed, 4 insertions(+), 15 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 015a84a..28e9914 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -1360,9 +1360,7 @@ >> # 4) A link type in the form 'link<subtype>' where subtype is a qdev >> # device type name. Link properties form the device model graph. >> # >> -# Since: 1.1 >> -# >> -# Notes: This type is experimental. Its syntax may change in future releases. >> +# Since: 1.2 >> ## >> { 'type': 'ObjectPropertyInfo', >> 'data': { 'name': 'str', 'type': 'str' } } >> @@ -1379,10 +1377,7 @@ >> # Returns: a list of @ObjectPropertyInfo that describe the properties of the >> # object. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental. It's syntax may change in future >> -# releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-list', >> 'data': { 'path': 'str' }, >> @@ -1418,9 +1413,7 @@ >> # returns as #str pathnames. All integer property types (u8, u16, etc) >> # are returned as #int. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-get', >> 'data': { 'path': 'str', 'property': 'str' }, >> @@ -1439,9 +1432,7 @@ >> # @value: a value who's type is appropriate for the property type. See @qom-get >> # for a description of type mapping. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-set', >> 'data': { 'path': 'str', 'property': 'str', 'value': 'visitor' }, >> @@ -1719,8 +1710,6 @@ >> # Returns: a list of @ObjectTypeInfo or an empty list if no results are found >> # >> # Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> ## >> { 'command': 'qom-list-types', >> 'data': { '*implements': 'str', '*abstract': 'bool' },
diff --git a/qapi-schema.json b/qapi-schema.json index 015a84a..28e9914 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1360,9 +1360,7 @@ # 4) A link type in the form 'link<subtype>' where subtype is a qdev # device type name. Link properties form the device model graph. # -# Since: 1.1 -# -# Notes: This type is experimental. Its syntax may change in future releases. +# Since: 1.2 ## { 'type': 'ObjectPropertyInfo', 'data': { 'name': 'str', 'type': 'str' } } @@ -1379,10 +1377,7 @@ # Returns: a list of @ObjectPropertyInfo that describe the properties of the # object. # -# Since: 1.1 -# -# Notes: This command is experimental. It's syntax may change in future -# releases. +# Since: 1.2 ## { 'command': 'qom-list', 'data': { 'path': 'str' }, @@ -1418,9 +1413,7 @@ # returns as #str pathnames. All integer property types (u8, u16, etc) # are returned as #int. # -# Since: 1.1 -# -# Notes: This command is experimental and may change syntax in future releases. +# Since: 1.2 ## { 'command': 'qom-get', 'data': { 'path': 'str', 'property': 'str' }, @@ -1439,9 +1432,7 @@ # @value: a value who's type is appropriate for the property type. See @qom-get # for a description of type mapping. # -# Since: 1.1 -# -# Notes: This command is experimental and may change syntax in future releases. +# Since: 1.2 ## { 'command': 'qom-set', 'data': { 'path': 'str', 'property': 'str', 'value': 'visitor' }, @@ -1719,8 +1710,6 @@ # Returns: a list of @ObjectTypeInfo or an empty list if no results are found # # Since: 1.1 -# -# Notes: This command is experimental and may change syntax in future releases. ## { 'command': 'qom-list-types', 'data': { '*implements': 'str', '*abstract': 'bool' },
We've had a cycle to tweak. It is time to commit to supporting them. Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> --- qapi-schema.json | 19 ++++--------------- 1 files changed, 4 insertions(+), 15 deletions(-)