From patchwork Wed May 30 16:19:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 162026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A6603B7060 for ; Thu, 31 May 2012 02:19:35 +1000 (EST) Received: from localhost ([::1]:38425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZlcT-0004QN-H9 for incoming@patchwork.ozlabs.org; Wed, 30 May 2012 12:19:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZlcI-0004O4-Nh for qemu-devel@nongnu.org; Wed, 30 May 2012 12:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZlcC-00050g-Jc for qemu-devel@nongnu.org; Wed, 30 May 2012 12:19:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZlcC-00050Z-Bk for qemu-devel@nongnu.org; Wed, 30 May 2012 12:19:16 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4UGJBfW026731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 12:19:11 -0400 Received: from nial.brq.redhat.com (dhcp-1-247.brq.redhat.com [10.34.1.247]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4UGJ84W012526; Wed, 30 May 2012 12:19:08 -0400 From: Igor Mammedov To: qemu-devel@nongnu.org Date: Wed, 30 May 2012 18:19:07 +0200 Message-Id: <1338394747-17427-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: pbonzini@redhat.com, aliguori@us.ibm.com, i.mitsyanko@samsung.com, afaerber@suse.de, alexander_barabash@mentor.com Subject: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) => object_dynamic_cast(obj, typename) => object_is_type(obj, target_type) => type_is_ancestor(obj->class->type, target_type); ^^^ so abort earlier and print nice message instead of SIGSEGV Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- qom/object.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index 00bb3b0..444e2fc 100644 --- a/qom/object.c +++ b/qom/object.c @@ -481,6 +481,8 @@ Object *object_dynamic_cast_assert(Object *obj, const char *typename) { Object *inst; + g_assert(obj != NULL); + inst = object_dynamic_cast(obj, typename); if (!inst) {