diff mbox

[01/14] qerror: extend QERR_TOO_MANY_FILES

Message ID 1338387301-10074-2-git-send-email-lcapitulino@redhat.com
State New
Headers show

Commit Message

Luiz Capitulino May 30, 2012, 2:14 p.m. UTC
Specify it's too many open files in system (ENFILE).

There's no compatibility issue because QERR_TOO_MANY_FILES is actually
not used today.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qerror.c | 4 ++--
 qerror.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Paolo Bonzini May 31, 2012, 10:43 a.m. UTC | #1
Il 30/05/2012 16:14, Luiz Capitulino ha scritto:
> Specify it's too many open files in system (ENFILE).
> 
> There's no compatibility issue because QERR_TOO_MANY_FILES is actually
> not used today.

Let's kill it then. :)

Are there any others?

Paolo

> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qerror.c | 4 ++--
>  qerror.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qerror.c b/qerror.c
> index 92c4eff..6c78759 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -283,8 +283,8 @@ static const QErrorStringTable qerror_table[] = {
>          .desc      = "Could not set password",
>      },
>      {
> -        .error_fmt = QERR_TOO_MANY_FILES,
> -        .desc      = "Too many open files",
> +        .error_fmt = QERR_TOO_MANY_FILES_SYS,
> +        .desc      = "Too many open files in system",
>      },
>      {
>          .error_fmt = QERR_UNDEFINED_ERROR,
> diff --git a/qerror.h b/qerror.h
> index b4c8758..fb7c642 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -233,8 +233,8 @@ QError *qobject_to_qerror(const QObject *obj);
>  #define QERR_SET_PASSWD_FAILED \
>      "{ 'class': 'SetPasswdFailed', 'data': {} }"
>  
> -#define QERR_TOO_MANY_FILES \
> -    "{ 'class': 'TooManyFiles', 'data': {} }"
> +#define QERR_TOO_MANY_FILES_SYS \
> +    "{ 'class': 'TooManyFilesInSystem', 'data': {} }"
>  
>  #define QERR_UNDEFINED_ERROR \
>      "{ 'class': 'UndefinedError', 'data': {} }"
Luiz Capitulino May 31, 2012, 2:06 p.m. UTC | #2
On Thu, 31 May 2012 12:43:24 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 30/05/2012 16:14, Luiz Capitulino ha scritto:
> > Specify it's too many open files in system (ENFILE).
> > 
> > There's no compatibility issue because QERR_TOO_MANY_FILES is actually
> > not used today.
> 
> Let's kill it then. :)

It's used in this series.
diff mbox

Patch

diff --git a/qerror.c b/qerror.c
index 92c4eff..6c78759 100644
--- a/qerror.c
+++ b/qerror.c
@@ -283,8 +283,8 @@  static const QErrorStringTable qerror_table[] = {
         .desc      = "Could not set password",
     },
     {
-        .error_fmt = QERR_TOO_MANY_FILES,
-        .desc      = "Too many open files",
+        .error_fmt = QERR_TOO_MANY_FILES_SYS,
+        .desc      = "Too many open files in system",
     },
     {
         .error_fmt = QERR_UNDEFINED_ERROR,
diff --git a/qerror.h b/qerror.h
index b4c8758..fb7c642 100644
--- a/qerror.h
+++ b/qerror.h
@@ -233,8 +233,8 @@  QError *qobject_to_qerror(const QObject *obj);
 #define QERR_SET_PASSWD_FAILED \
     "{ 'class': 'SetPasswdFailed', 'data': {} }"
 
-#define QERR_TOO_MANY_FILES \
-    "{ 'class': 'TooManyFiles', 'data': {} }"
+#define QERR_TOO_MANY_FILES_SYS \
+    "{ 'class': 'TooManyFilesInSystem', 'data': {} }"
 
 #define QERR_UNDEFINED_ERROR \
     "{ 'class': 'UndefinedError', 'data': {} }"