| Message ID | 1338159200-7502-1-git-send-email-andreas.faerber@web.de |
|---|---|
| State | New |
| Headers | show |
Am 28.05.2012 00:53, schrieb Andreas Färber: > accept() expects address_len to point to the length of the sockaddr on > input. Initialize it accordingly. > > Resolves an assertion due to EFAULT on illumos. > > Signed-off-by: Andreas Färber <andreas.faerber@web.de> Ping? Verifiable by looking at the Linux man page. /-F > --- > tests/libqtest.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 6d333ef..1d73fd1 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -74,6 +74,7 @@ static int socket_accept(int sock) > socklen_t addrlen; > int ret; > > + addrlen = sizeof(addr); > do { > ret = accept(sock, (struct sockaddr *)&addr, &addrlen); > } while (ret == -1 && errno == EINTR);
On Mon, May 28, 2012 at 12:53:20AM +0200, Andreas Färber wrote: > accept() expects address_len to point to the length of the sockaddr on > input. Initialize it accordingly. > > Resolves an assertion due to EFAULT on illumos. > > Signed-off-by: Andreas Färber <andreas.faerber@web.de> > --- > tests/libqtest.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
diff --git a/tests/libqtest.c b/tests/libqtest.c index 6d333ef..1d73fd1 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -74,6 +74,7 @@ static int socket_accept(int sock) socklen_t addrlen; int ret; + addrlen = sizeof(addr); do { ret = accept(sock, (struct sockaddr *)&addr, &addrlen); } while (ret == -1 && errno == EINTR);
accept() expects address_len to point to the length of the sockaddr on input. Initialize it accordingly. Resolves an assertion due to EFAULT on illumos. Signed-off-by: Andreas Färber <andreas.faerber@web.de> --- tests/libqtest.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)