From patchwork Wed May 23 15:14:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiyong Wu X-Patchwork-Id: 160954 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4EF4BB6FB9 for ; Thu, 24 May 2012 01:53:34 +1000 (EST) Received: from localhost ([::1]:58935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDsS-0000fq-9C for incoming@patchwork.ozlabs.org; Wed, 23 May 2012 11:53:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDsA-0000JQ-DS for qemu-devel@nongnu.org; Wed, 23 May 2012 11:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXDs4-0002oO-6s for qemu-devel@nongnu.org; Wed, 23 May 2012 11:53:13 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:59652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDs4-0002nh-0f for qemu-devel@nongnu.org; Wed, 23 May 2012 11:53:08 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 May 2012 09:53:06 -0600 Received: from d01dlp03.pok.ibm.com (9.56.224.17) by e39.co.us.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 May 2012 09:53:03 -0600 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 3B6D3C92626 for ; Wed, 23 May 2012 11:20:48 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4NFKjaw062842 for ; Wed, 23 May 2012 11:20:45 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4NFJitB026204 for ; Wed, 23 May 2012 12:19:44 -0300 Received: from us.ibm.com (f15.cn.ibm.com [9.115.118.120] (may be forged)) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q4NFJeJC025785; Wed, 23 May 2012 12:19:41 -0300 Received: by us.ibm.com (sSMTP sendmail emulation); Wed, 23 May 2012 23:19:33 +0800 From: zwu.kernel@gmail.com To: qemu-devel@nongnu.org Date: Wed, 23 May 2012 23:14:05 +0800 Message-Id: <1337786045-2277-16-git-send-email-zwu.kernel@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com> References: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12052315-4242-0000-0000-000001C1934E X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.97.110.160 Cc: pbonzini@redhat.com, wuzhy@linux.vnet.ibm.com, linuxram@us.ibm.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH v2 15/15] net: invoke qemu_can_send_packet only before net queue sending function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/queue.c | 4 ++-- net/slirp.c | 7 ------- net/tap.c | 2 +- slirp/if.c | 5 ----- slirp/libslirp.h | 1 - 5 files changed, 3 insertions(+), 16 deletions(-) diff --git a/net/queue.c b/net/queue.c index 0afd783..d2e57de 100644 --- a/net/queue.c +++ b/net/queue.c @@ -176,7 +176,7 @@ ssize_t qemu_net_queue_send(NetQueue *queue, { ssize_t ret; - if (queue->delivering) { + if (queue->delivering || !qemu_can_send_packet(sender)) { return qemu_net_queue_append(queue, sender, flags, data, size, NULL); } @@ -200,7 +200,7 @@ ssize_t qemu_net_queue_send_iov(NetQueue *queue, { ssize_t ret; - if (queue->delivering) { + if (queue->delivering || !qemu_can_send_packet(sender)) { return qemu_net_queue_append_iov(queue, sender, flags, iov, iovcnt, NULL); } diff --git a/net/slirp.c b/net/slirp.c index a6ede2b..248f7ff 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -96,13 +96,6 @@ static void slirp_smb_cleanup(SlirpState *s); static inline void slirp_smb_cleanup(SlirpState *s) { } #endif -int slirp_can_output(void *opaque) -{ - SlirpState *s = opaque; - - return qemu_can_send_packet(&s->nc); -} - void slirp_output(void *opaque, const uint8_t *pkt, int pkt_len) { SlirpState *s = opaque; diff --git a/net/tap.c b/net/tap.c index 65f45b8..7b1992b 100644 --- a/net/tap.c +++ b/net/tap.c @@ -210,7 +210,7 @@ static void tap_send(void *opaque) if (size == 0) { tap_read_poll(s, 0); } - } while (size > 0 && qemu_can_send_packet(&s->nc)); + } while (size > 0); } int tap_has_ufo(NetClientState *nc) diff --git a/slirp/if.c b/slirp/if.c index 096cf6f..533295d 100644 --- a/slirp/if.c +++ b/slirp/if.c @@ -177,11 +177,6 @@ void if_start(Slirp *slirp) } while (ifm_next) { - /* check if we can really output */ - if (!slirp_can_output(slirp->opaque)) { - break; - } - ifm = ifm_next; from_batchq = next_from_batchq; diff --git a/slirp/libslirp.h b/slirp/libslirp.h index 77527ad..9b471b5 100644 --- a/slirp/libslirp.h +++ b/slirp/libslirp.h @@ -25,7 +25,6 @@ void slirp_select_poll(fd_set *readfds, fd_set *writefds, fd_set *xfds, void slirp_input(Slirp *slirp, const uint8_t *pkt, int pkt_len); /* you must provide the following functions: */ -int slirp_can_output(void *opaque); void slirp_output(void *opaque, const uint8_t *pkt, int pkt_len); int slirp_add_hostfwd(Slirp *slirp, int is_udp,