From patchwork Wed May 23 15:14:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiyong Wu X-Patchwork-Id: 160953 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2A07EB6FB7 for ; Thu, 24 May 2012 01:53:03 +1000 (EST) Received: from localhost ([::1]:56646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDrx-0007s4-4M for incoming@patchwork.ozlabs.org; Wed, 23 May 2012 11:53:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDrn-0007mU-CV for qemu-devel@nongnu.org; Wed, 23 May 2012 11:52:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXDrk-0002gn-R7 for qemu-devel@nongnu.org; Wed, 23 May 2012 11:52:50 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:59386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDrk-0002gO-Jg for qemu-devel@nongnu.org; Wed, 23 May 2012 11:52:48 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 May 2012 09:52:46 -0600 Received: from d01dlp03.pok.ibm.com (9.56.224.17) by e39.co.us.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 May 2012 09:52:44 -0600 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 87E413C60ADE for ; Wed, 23 May 2012 11:20:40 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4NFKS5m18088168 for ; Wed, 23 May 2012 11:20:28 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4NFJg2L013318 for ; Wed, 23 May 2012 11:19:42 -0400 Received: from us.ibm.com (f15.cn.ibm.com [9.115.118.120] (may be forged)) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q4NFJZGY012430; Wed, 23 May 2012 11:19:36 -0400 Received: by us.ibm.com (sSMTP sendmail emulation); Wed, 23 May 2012 23:19:28 +0800 From: zwu.kernel@gmail.com To: qemu-devel@nongnu.org Date: Wed, 23 May 2012 23:14:04 +0800 Message-Id: <1337786045-2277-15-git-send-email-zwu.kernel@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com> References: <1337786045-2277-1-git-send-email-zwu.kernel@gmail.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12052315-4242-0000-0000-000001C19295 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.97.110.160 Cc: pbonzini@redhat.com, wuzhy@linux.vnet.ibm.com, linuxram@us.ibm.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH v2 14/15] net: cleanup deliver/deliver_iov func pointers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c | 35 +++++++++++------------------------ net.h | 11 +++++++++++ net/queue.c | 13 ++++--------- net/queue.h | 17 ++--------------- 4 files changed, 28 insertions(+), 48 deletions(-) diff --git a/net.c b/net.c index 8c8e703..7360d26 100644 --- a/net.c +++ b/net.c @@ -181,17 +181,6 @@ static char *assign_name(NetClientState *nc1, const char *model) return g_strdup(buf); } -static ssize_t qemu_deliver_packet(NetClientState *sender, - unsigned flags, - const uint8_t *data, - size_t size, - void *opaque); -static ssize_t qemu_deliver_packet_iov(NetClientState *sender, - unsigned flags, - const struct iovec *iov, - int iovcnt, - void *opaque); - NetClientState *qemu_new_net_client(NetClientInfo *info, NetClientState *peer, const char *model, @@ -218,9 +207,7 @@ NetClientState *qemu_new_net_client(NetClientInfo *info, } QTAILQ_INSERT_TAIL(&net_clients, nc, next); - nc->send_queue = qemu_new_net_queue(qemu_deliver_packet, - qemu_deliver_packet_iov, - nc); + nc->send_queue = qemu_new_net_queue(nc); return nc; } @@ -324,11 +311,11 @@ int qemu_can_send_packet(NetClientState *sender) return 1; } -static ssize_t qemu_deliver_packet(NetClientState *sender, - unsigned flags, - const uint8_t *data, - size_t size, - void *opaque) +ssize_t qemu_deliver_packet(NetClientState *sender, + unsigned flags, + const uint8_t *data, + size_t size, + void *opaque) { NetClientState *nc = opaque; ssize_t ret; @@ -421,11 +408,11 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, return nc->info->receive(nc, buffer, offset); } -static ssize_t qemu_deliver_packet_iov(NetClientState *sender, - unsigned flags, - const struct iovec *iov, - int iovcnt, - void *opaque) +ssize_t qemu_deliver_packet_iov(NetClientState *sender, + unsigned flags, + const struct iovec *iov, + int iovcnt, + void *opaque) { NetClientState *nc = opaque; diff --git a/net.h b/net.h index 250669a..7779b6a 100644 --- a/net.h +++ b/net.h @@ -112,6 +112,17 @@ void qemu_check_nic_model(NICInfo *nd, const char *model); int qemu_find_nic_model(NICInfo *nd, const char * const *models, const char *default_model); +ssize_t qemu_deliver_packet(NetClientState *sender, + unsigned flags, + const uint8_t *data, + size_t size, + void *opaque); +ssize_t qemu_deliver_packet_iov(NetClientState *sender, + unsigned flags, + const struct iovec *iov, + int iovcnt, + void *opaque); + void do_info_network(Monitor *mon); /* NIC info */ diff --git a/net/queue.c b/net/queue.c index 35c3463..0afd783 100644 --- a/net/queue.c +++ b/net/queue.c @@ -23,6 +23,7 @@ #include "net/queue.h" #include "qemu-queue.h" +#include "net.h" /* The delivery handler may only return zero if it will call * qemu_net_queue_flush() when it determines that it is once again able @@ -48,8 +49,6 @@ struct NetPacket { }; struct NetQueue { - NetPacketDeliver *deliver; - NetPacketDeliverIOV *deliver_iov; void *opaque; QTAILQ_HEAD(packets, NetPacket) packets; @@ -57,16 +56,12 @@ struct NetQueue { unsigned delivering : 1; }; -NetQueue *qemu_new_net_queue(NetPacketDeliver *deliver, - NetPacketDeliverIOV *deliver_iov, - void *opaque) +NetQueue *qemu_new_net_queue(void *opaque) { NetQueue *queue; queue = g_malloc0(sizeof(NetQueue)); - queue->deliver = deliver; - queue->deliver_iov = deliver_iov; queue->opaque = opaque; QTAILQ_INIT(&queue->packets); @@ -151,7 +146,7 @@ static ssize_t qemu_net_queue_deliver(NetQueue *queue, ssize_t ret = -1; queue->delivering = 1; - ret = queue->deliver(sender, flags, data, size, queue->opaque); + ret = qemu_deliver_packet(sender, flags, data, size, queue->opaque); queue->delivering = 0; return ret; @@ -166,7 +161,7 @@ static ssize_t qemu_net_queue_deliver_iov(NetQueue *queue, ssize_t ret = -1; queue->delivering = 1; - ret = queue->deliver_iov(sender, flags, iov, iovcnt, queue->opaque); + ret = qemu_deliver_packet_iov(sender, flags, iov, iovcnt, queue->opaque); queue->delivering = 0; return ret; diff --git a/net/queue.h b/net/queue.h index d8eac0b..9d44a9b 100644 --- a/net/queue.h +++ b/net/queue.h @@ -31,24 +31,11 @@ typedef struct NetQueue NetQueue; typedef void (NetPacketSent) (NetClientState *sender, ssize_t ret); -typedef ssize_t (NetPacketDeliver) (NetClientState *sender, - unsigned flags, - const uint8_t *buf, - size_t size, - void *opaque); - -typedef ssize_t (NetPacketDeliverIOV) (NetClientState *sender, - unsigned flags, - const struct iovec *iov, - int iovcnt, - void *opaque); - #define QEMU_NET_PACKET_FLAG_NONE 0 #define QEMU_NET_PACKET_FLAG_RAW (1<<0) -NetQueue *qemu_new_net_queue(NetPacketDeliver *deliver, - NetPacketDeliverIOV *deliver_iov, - void *opaque); +NetQueue *qemu_new_net_queue(void *opaque); + void qemu_del_net_queue(NetQueue *queue); ssize_t qemu_net_queue_send(NetQueue *queue,