From patchwork Wed May 9 09:24:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Meyering X-Patchwork-Id: 157956 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 59B22B6EF1 for ; Wed, 9 May 2012 23:35:12 +1000 (EST) Received: from localhost ([::1]:58816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS6WC-0007Xx-MS for incoming@patchwork.ozlabs.org; Wed, 09 May 2012 09:01:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS38E-00063i-2m for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS385-0002Am-Gv for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:25 -0400 Received: from mx.meyering.net ([88.168.87.75]:36915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS385-000241-6X for qemu-devel@nongnu.org; Wed, 09 May 2012 05:24:17 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id B888A612F2; Wed, 9 May 2012 11:24:13 +0200 (CEST) From: Jim Meyering To: qemu-devel@nongnu.org Date: Wed, 9 May 2012 11:24:03 +0200 Message-Id: <1336555446-20180-20-git-send-email-jim@meyering.net> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1336555446-20180-1-git-send-email-jim@meyering.net> References: <1336555446-20180-1-git-send-email-jim@meyering.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 88.168.87.75 X-Mailman-Approved-At: Wed, 09 May 2012 08:59:40 -0400 Cc: Jim Meyering , Kevin Wolf Subject: [Qemu-devel] [PATCH 19/22] qcow2: mark this file's sole strncpy use as justified X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jim Meyering Signed-off-by: Jim Meyering --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 8c60a6f..abc985e 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -990,6 +990,7 @@ int qcow2_update_header(BlockDriverState *bs) goto fail; } + /* Using strncpy is ok here, since buf is not NUL-terminated. */ strncpy(buf, bs->backing_file, buflen); header->backing_file_offset = cpu_to_be64(buf - ((char*) header));