From patchwork Tue May 8 14:51:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 157707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 68582B6FA5 for ; Wed, 9 May 2012 00:52:57 +1000 (EST) Received: from localhost ([::1]:32845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRlmZ-0008Dm-4f for incoming@patchwork.ozlabs.org; Tue, 08 May 2012 10:52:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRlmD-0007yO-LP for qemu-devel@nongnu.org; Tue, 08 May 2012 10:52:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRlm7-0007VG-FA for qemu-devel@nongnu.org; Tue, 08 May 2012 10:52:33 -0400 Received: from mail-pz0-f47.google.com ([209.85.210.47]:52083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRlm7-0007Sn-6K for qemu-devel@nongnu.org; Tue, 08 May 2012 10:52:27 -0400 Received: by mail-pz0-f47.google.com with SMTP id h21so8313251dal.34 for ; Tue, 08 May 2012 07:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=wa1/q07VnplsZ5GL5ZOCeL/5PpmLBLUuBNEM90la+5g=; b=ZA4B458uyb406CxdB3qCMWa6rvlmROm3d720/izeBLZ05NqHQw+TjcoiFPHoPo24HP DcGl116d0AXwQgQGku83S9lXgFHVSHqIo7T9SaZxUWD47bJEQkVgWW7V4ObpYY5kNCbE SigGJ1uasdKQQsdNUFAVElvP8j0KMLNRZ1gt18C16A7HbKjB6+/tL2rMdz6voHe3Q2IB AtXL6ZPA8w39VedClhLE6h6yQ3aBGm/K4P1nh25MStr8WUJD6mWBz0csmZz+PtETIw+k CB6FGLOw2HyUqeuv+EbnQRSZ5GsOEv/x3OYAzn+AEqksBHHlsC8811+PWmPx5ko32rGq snsA== Received: by 10.68.223.231 with SMTP id qx7mr9015921pbc.134.1336488746282; Tue, 08 May 2012 07:52:26 -0700 (PDT) Received: from yakj.usersys.redhat.com (93-34-182-16.ip50.fastwebnet.it. [93.34.182.16]) by mx.google.com with ESMTPS id i1sm2604863pbv.49.2012.05.08.07.52.23 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 May 2012 07:52:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 8 May 2012 16:51:43 +0200 Message-Id: <1336488722-13120-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.10.1 In-Reply-To: <1336488722-13120-1-git-send-email-pbonzini@redhat.com> References: <1336488722-13120-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.47 Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 1.1 03/22] block: do not reuse the backing file across bdrv_close/bdrv_open X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is another bug caused by not doing a full cleanup of the BDS across close/open. This was found with mirroring by Shaolong Hu, but it can probably be reproduced also with eject or change. Signed-off-by: Paolo Bonzini --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index 6dc0d44..271f109 100644 --- a/block.c +++ b/block.c @@ -878,6 +878,8 @@ void bdrv_close(BlockDriverState *bs) bs->opaque = NULL; bs->drv = NULL; bs->copy_on_read = 0; + bs->backing_file[0] = '\0'; + bs->backing_format[0] = '\0'; if (bs->file != NULL) { bdrv_close(bs->file);