From patchwork Sun May 6 19:38:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 157191 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DE5CAB6F13 for ; Mon, 7 May 2012 05:39:01 +1000 (EST) Received: from localhost ([::1]:59463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SR7IG-0003VE-32 for incoming@patchwork.ozlabs.org; Sun, 06 May 2012 15:38:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SR7I9-0003Ui-3Z for qemu-devel@nongnu.org; Sun, 06 May 2012 15:38:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SR7I7-0005pC-BX for qemu-devel@nongnu.org; Sun, 06 May 2012 15:38:48 -0400 Received: from mout.web.de ([212.227.15.3]:51648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SR7I4-0005gF-2k; Sun, 06 May 2012 15:38:44 -0400 Received: from localhost.localdomain ([84.148.46.223]) by smtp.web.de (mrweb001) with ESMTPA (Nemesis) id 0MQvxm-1SaRUY0zxm-00ULwz; Sun, 06 May 2012 21:38:36 +0200 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= To: qemu-devel@nongnu.org Date: Sun, 6 May 2012 21:38:33 +0200 Message-Id: <1336333113-773-1-git-send-email-andreas.faerber@web.de> X-Mailer: git-send-email 1.7.7 MIME-Version: 1.0 X-Provags-ID: V02:K0:V0hzpofxHHp57rBYWgMvNC89+uO7MMAbWG0FPeZU93C saU0ESVJwPbOCRZUrjeqf9MsyFNG60PW4a8alhqSM1SbmijMpu d/vjcO0DRcWkTpdDiKdPh9eCSV8gx9IsyE9d2gYVjrawmspn/0 Fbvtq24X1BSNkqh4wZ8Sm27PrvHH7fF+pgNM4tGUYQtX44b0hy OZWf7/dpH56qLDZpQIKWw== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.15.3 Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , qemu-ppc@nongnu.org Subject: [Qemu-devel] [RFC] tcg/ppc: Do not overwrite lower address word on Darwin and AIX X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org For targets where TARGET_LONG_BITS != 32, i.e. 64-bit guests, addr_reg is moved to r4. For hosts with TCG_TARGET_CALL_ALIGN_ARGS either data_reg2 or data_reg or a masked version thereof would overwrite r4. Place it in r5 instead, matching TCG_TARGET_CALL_ALIGN_ARGS hosts. This might explain crashes observed on Darwin/ppc but not on ppc64. Signed-off-by: Andreas Färber --- tcg/ppc/tcg-target.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index dc40716..4b85c89 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -816,11 +816,7 @@ static void tcg_out_qemu_st (TCGContext *s, const TCGArg *args, int opc) #else tcg_out_mov (s, TCG_TYPE_I32, 3, addr_reg2); tcg_out_mov (s, TCG_TYPE_I32, 4, addr_reg); -#ifdef TCG_TARGET_CALL_ALIGN_ARGS ir = 5; -#else - ir = 4; -#endif #endif switch (opc) {