From patchwork Fri May 4 20:20:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 156984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 131DCB7014 for ; Sat, 5 May 2012 06:21:26 +1000 (EST) Received: from localhost ([::1]:43786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQP0F-0006Jy-TE for incoming@patchwork.ozlabs.org; Fri, 04 May 2012 16:21:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQOzl-0005J0-6M for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQOzi-0006Oi-Bt for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQOzi-0006OG-4O for qemu-devel@nongnu.org; Fri, 04 May 2012 16:20:50 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q44KKY3j012724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 May 2012 16:20:34 -0400 Received: from localhost (ovpn-116-75.ams2.redhat.com [10.36.116.75]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q44KKOws007753; Fri, 4 May 2012 16:20:32 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Fri, 4 May 2012 17:20:20 -0300 Message-Id: <1336162822-13161-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com> References: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, mprivozn@redhat.com Subject: [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-suspend-disk to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino --- qapi-schema-guest.json | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 0aa9f91..8ea7805 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -361,17 +361,19 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# Returns: nothing on success +# Returns: This command does NOT return a response on success. There's a +# high chance the command succeeded if the VM exits with a zero exit status, +# but the VM could also exit due to other reasons. +# +# The following errors may be returned: # If suspend to disk is not supported, Unsupported # -# Notes: o This is an asynchronous request. There's no guarantee a response -# will be sent -# o It's strongly recommended to issue the guest-sync command before -# sending commands when the guest resumes +# Notes: It's strongly recommended to issue the guest-sync command before +# sending commands when the guest resumes # # Since: 1.1 ## -{ 'command': 'guest-suspend-disk' } +{ 'command': 'guest-suspend-disk', 'success-response': 'no' } ## # @guest-suspend-ram