From patchwork Wed Apr 4 06:39:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeny Voevodin X-Patchwork-Id: 150610 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 603DCB6FFF for ; Wed, 4 Apr 2012 16:40:06 +1000 (EST) Received: from localhost ([::1]:57971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFJsy-00019G-1t for incoming@patchwork.ozlabs.org; Wed, 04 Apr 2012 02:40:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFJsT-00008n-FE for qemu-devel@nongnu.org; Wed, 04 Apr 2012 02:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFJsQ-00022z-TQ for qemu-devel@nongnu.org; Wed, 04 Apr 2012 02:39:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:60639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFJsQ-00022J-N1 for qemu-devel@nongnu.org; Wed, 04 Apr 2012 02:39:30 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN Received: from euspt1 ([210.118.77.13]) by mailout3.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M1X00ENWZTALT10@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 04 Apr 2012 07:39:10 +0100 (BST) Received: from evvoevodinPC.rnd.samsung.ru ([106.109.9.191]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M1X00N6SZTK1O@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 04 Apr 2012 07:39:26 +0100 (BST) Date: Wed, 04 Apr 2012 10:39:16 +0400 From: Evgeny Voevodin In-reply-to: <1333521556-31662-1-git-send-email-e.voevodin@samsung.com> To: qemu-devel@nongnu.org Message-id: <1333521556-31662-3-git-send-email-e.voevodin@samsung.com> X-Mailer: git-send-email 1.7.5.4 References: <1333521556-31662-1-git-send-email-e.voevodin@samsung.com> X-detected-operating-system: by eggs.gnu.org: Solaris 9.1 X-Received-From: 210.118.77.13 Cc: peter.maydell@linaro.org, i.mitsyanko@samsung.com, Evgeny Voevodin , kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com Subject: [Qemu-devel] [PATCH 2/2] hw/exynos4210_combiner.c: Drop excessive read/write access check. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Access to reserved area at offset higher than 0x3c is allowed in External Combiner. Samsung Galaxy Kernel implements this. So, drop excessive checks in read/write functions. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell --- hw/exynos4210_combiner.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hw/exynos4210_combiner.c b/hw/exynos4210_combiner.c index 6110c19..80af22c 100644 --- a/hw/exynos4210_combiner.c +++ b/hw/exynos4210_combiner.c @@ -184,11 +184,6 @@ exynos4210_combiner_read(void *opaque, target_phys_addr_t offset, unsigned size) uint32_t reg_n; /* Register number inside the quad */ uint32_t val; - if (s->external && (offset > 0x3c && offset != 0x100)) { - hw_error("exynos4210.combiner: unallowed read access at offset 0x" - TARGET_FMT_plx "\n", offset); - } - req_quad_base_n = offset >> 4; grp_quad_base_n = req_quad_base_n << 2; reg_n = (offset - (req_quad_base_n << 4)) >> 2; @@ -281,11 +276,6 @@ static void exynos4210_combiner_write(void *opaque, target_phys_addr_t offset, uint32_t grp_quad_base_n; /* Base of group quad */ uint32_t reg_n; /* Register number inside the quad */ - if (s->external && (offset > 0x3c && offset != 0x100)) { - hw_error("exynos4210.combiner: unallowed write access at offset 0x" - TARGET_FMT_plx "\n", offset); - } - req_quad_base_n = offset >> 4; grp_quad_base_n = req_quad_base_n << 2; reg_n = (offset - (req_quad_base_n << 4)) >> 2;