Message ID | 1332934907-24080-2-git-send-email-anthony.perard@citrix.com |
---|---|
State | New |
Headers | show |
On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote: You really should say why this is added.. It is so odd just to have 'add this' without any justification. Can you at least say: "We are using this in our quirk lookup provided by patch titled: XXXYYY" ? > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > hw/pci_ids.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h > index e8235a7..649e6b3 100644 > --- a/hw/pci_ids.h > +++ b/hw/pci_ids.h > @@ -118,6 +118,7 @@ > #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 > #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a > #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c > +#define PCI_DEVICE_ID_INTEL_82599_SFP_VF 0x10ed > > #define PCI_VENDOR_ID_XEN 0x5853 > #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001 > -- > Anthony PERARD > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
On Wed, Mar 28, 2012 at 19:53, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > You really should say why this is added.. It is so odd just to have > 'add this' without any justification. Can you at least say: > > "We are using this in our quirk lookup provided by patch > titled: XXXYYY" ? I will add this. Thanks,
diff --git a/hw/pci_ids.h b/hw/pci_ids.h index e8235a7..649e6b3 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -118,6 +118,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c +#define PCI_DEVICE_ID_INTEL_82599_SFP_VF 0x10ed #define PCI_VENDOR_ID_XEN 0x5853 #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001