From patchwork Tue Mar 13 13:49:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 146412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3519FB6EF3 for ; Wed, 14 Mar 2012 00:47:05 +1100 (EST) Received: from localhost ([::1]:47031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7S44-0008GK-Gg for incoming@patchwork.ozlabs.org; Tue, 13 Mar 2012 09:47:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7S3a-00080O-F7 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:46:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7S3V-0006Cw-35 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:46:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7S3U-0006Cs-Ri for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:46:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2DDkNE7031362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Mar 2012 09:46:23 -0400 Received: from dhcp-5-188.str.redhat.com (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2DDkLQu004547; Tue, 13 Mar 2012 09:46:22 -0400 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Tue, 13 Mar 2012 14:49:55 +0100 Message-Id: <1331646595-24650-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, pbonzini@redhat.com Subject: [Qemu-devel] [PATCH] ide: IDENTIFY word 86 bit 14 is reserved X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reserved bits should be cleared to zero. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- hw/ide/core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 6f06d28..771811c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -150,7 +150,7 @@ static void ide_identify(IDEState *s) else put_le16(p + 85, (1 << 14) | 1); /* 13=flush_cache_ext,12=flush_cache,10=lba48 */ - put_le16(p + 86, (1 << 14) | (1 << 13) | (1 <<12) | (1 << 10)); + put_le16(p + 86, (1 << 13) | (1 <<12) | (1 << 10)); /* 14=set to 1, 1=smart self test, 0=smart error logging */ put_le16(p + 87, (1 << 14) | 0); put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */