From patchwork Mon Mar 12 09:34:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 146054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 243A7B6FA7 for ; Mon, 12 Mar 2012 21:05:49 +1100 (EST) Received: from localhost ([::1]:34418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S71bE-0005T4-RZ for incoming@patchwork.ozlabs.org; Mon, 12 Mar 2012 05:31:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S71as-0004ly-4x for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:31:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S71am-0006GO-1e for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:31:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S71al-0006G9-Qj for qemu-devel@nongnu.org; Mon, 12 Mar 2012 05:30:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2C9Uv4O029581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Mar 2012 05:30:57 -0400 Received: from dhcp-5-188.str.redhat.com (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2C9UsUi015001; Mon, 12 Mar 2012 05:30:56 -0400 From: Kevin Wolf To: stefanha@gmail.com Date: Mon, 12 Mar 2012 10:34:28 +0100 Message-Id: <1331544868-31655-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1331544868-31655-1-git-send-email-kwolf@redhat.com> References: <1331544868-31655-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf --- scripts/tracetool | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 4c9951d..f892af4 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -81,6 +81,10 @@ get_args() args=${1#*\(} args=${args%%\)*} echo "$args" + + if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then + echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n " + fi } # Get the argument name list of a trace event