From patchwork Thu Mar 1 13:25:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Harsh Prateek Bora X-Patchwork-Id: 144036 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 04B3B1007D4 for ; Fri, 2 Mar 2012 01:37:21 +1100 (EST) Received: from localhost ([::1]:55503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S362n-00061i-Dg for incoming@patchwork.ozlabs.org; Thu, 01 Mar 2012 08:27:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S361W-00035i-BW for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:26:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3615-0000Vu-Py for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:26:21 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:51526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3615-0000Sr-5Q for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:25:55 -0500 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Mar 2012 18:55:46 +0530 Received: from d28relay01.in.ibm.com (9.184.220.58) by e28smtp05.in.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 1 Mar 2012 18:55:43 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q21DPhkJ3309690 for ; Thu, 1 Mar 2012 18:55:43 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q21DPf6d013262 for ; Fri, 2 Mar 2012 00:25:42 +1100 Received: from harshbora.in.ibm.com ([9.124.35.242]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q21DPfJp013178; Fri, 2 Mar 2012 00:25:41 +1100 From: Harsh Prateek Bora To: qemu-devel@nongnu.org Date: Thu, 1 Mar 2012 18:55:37 +0530 Message-Id: <1330608340-9515-12-git-send-email-harsh@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <1330608340-9515-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1330608340-9515-1-git-send-email-harsh@linux.vnet.ibm.com> MIME-Version: 1.0 x-cbid: 12030113-8256-0000-0000-00000178D075 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 122.248.162.5 Cc: stefanha@gmail.com, vilanova@ac.upc.edu, aneesh.kumar@linux.vnet.ibm.com Subject: [Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Lluís Vilanova Signed-off-by: Lluís Vilanova Signed-off-by: Harsh Prateek Bora --- scripts/tracetool.py | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index dc93a1a..6cbbdd7 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -63,6 +63,13 @@ def get_format_descr(format_): return "" +def error_write(*lines): + sys.stderr.writelines(lines) + +def error(*lines): + error_write(*lines) + sys.exit(1) + ###################################################################### # backend auto-registration and format compatibility @@ -521,8 +528,9 @@ def main(): try: opts, args = getopt.getopt(sys.argv[1:], "", long_options) except getopt.GetoptError, err: - # print help information and exit: - print str(err) # will print something like "option -a not recognized" + # print help information and exit + # will print something like "option -a not recognized" + error_write(str(err)+"\n") usage() sys.exit(2) for opt, arg in opts: @@ -551,24 +559,19 @@ def main(): usage() if format_ not in _formats: - print "Unknown format: %s" % format_ - print + error_write("Unknown format: %s\n\n" % format_) usage() if backend not in _backends: - print "Unknown backend: %s" % backend - print + error_write("Unknown backend: %s\n\n" % backend) usage() if format_ == 'stap': if binary == "": - print '--binary is required for SystemTAP tapset generator' - sys.exit(1) + error("--binary is required for SystemTAP tapset generator\n") if not probeprefix and not targettype: - print '--target-type is required for SystemTAP tapset generator' - sys.exit(1) + error("--target-type is required for SystemTAP tapset generator\n") if not probeprefix and not targetarch: - print '--target-arch is required for SystemTAP tapset generator' - sys.exit(1) + error("--target-arch is required for SystemTAP tapset generator\n") if probeprefix == "": probeprefix = 'qemu.' + targettype + '.' + targetarch