From patchwork Sat Feb 18 17:11:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 142044 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 86CAEB6F99 for ; Sun, 19 Feb 2012 05:16:12 +1100 (EST) Received: from localhost ([::1]:56961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rynpw-0005De-U7 for incoming@patchwork.ozlabs.org; Sat, 18 Feb 2012 12:12:40 -0500 Received: from eggs.gnu.org ([140.186.70.92]:50318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rynpd-0004h9-Np for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rynpb-0005pv-QW for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:21 -0500 Received: from mail-bk0-f45.google.com ([209.85.214.45]:63774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rynpb-0005kY-I4 for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:19 -0500 Received: by mail-bk0-f45.google.com with SMTP id e19so4291536bku.4 for ; Sat, 18 Feb 2012 09:12:19 -0800 (PST) Received-SPF: pass (google.com: domain of jcmvbkbc@gmail.com designates 10.205.129.141 as permitted sender) client-ip=10.205.129.141; Authentication-Results: mr.google.com; spf=pass (google.com: domain of jcmvbkbc@gmail.com designates 10.205.129.141 as permitted sender) smtp.mail=jcmvbkbc@gmail.com; dkim=pass header.i=jcmvbkbc@gmail.com Received: from mr.google.com ([10.205.129.141]) by 10.205.129.141 with SMTP id hi13mr7532195bkc.7.1329585139153 (num_hops = 1); Sat, 18 Feb 2012 09:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=pxmAwmhDyd5ICDfWZ1DxER1UQiFkOkSX8j/tcTigPW8=; b=FsBRpZFOXOXoPI8yzH8da7cvwB+j6ohFL2rQnsBqjD9fyZhjZSsvDHe5pcTXnY4U4j VvdjdTBlE8qgsfBZG2KQuShQJO8/qBx1z+7kZcggzQGT05DyIyFwN8iXTAEhPaoWqFlN 9TnoYTzYtPRUKx9z9GL6W1zFSfJ6lONZ6ix10= Received: by 10.205.129.141 with SMTP id hi13mr6116892bkc.7.1329585139082; Sat, 18 Feb 2012 09:12:19 -0800 (PST) Received: from octofox.metropolis ([188.134.19.124]) by mx.google.com with ESMTPS id o7sm28887600bkw.16.2012.02.18.09.12.17 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Feb 2012 09:12:18 -0800 (PST) From: Max Filippov To: qemu-devel@nongnu.org Date: Sat, 18 Feb 2012 21:11:38 +0400 Message-Id: <1329585103-31371-7-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com> References: <1329564636-29883-1-git-send-email-jcmvbkbc@gmail.com> <1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.45 Cc: blauwirbel@gmail.com, Max Filippov , aliguori@us.ibm.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Max Filippov Reviewed-by: Meador Inge --- exec.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index b81677a..f105b43 100644 --- a/exec.c +++ b/exec.c @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, target_phys_addr_t addr, { check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE); switch (size) { - case 1: stb_phys(addr, val); - case 2: stw_phys(addr, val); - case 4: stl_phys(addr, val); + case 1: + stb_phys(addr, val); + break; + case 2: + stw_phys(addr, val); + break; + case 4: + stl_phys(addr, val); + break; default: abort(); } }