From patchwork Wed Feb 15 15:46:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harsh Prateek Bora X-Patchwork-Id: 141408 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BB59BB6FEE for ; Thu, 16 Feb 2012 08:01:35 +1100 (EST) Received: from localhost ([::1]:43130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxh5g-0001Sy-3I for incoming@patchwork.ozlabs.org; Wed, 15 Feb 2012 10:48:20 -0500 Received: from eggs.gnu.org ([140.186.70.92]:48350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxh4U-0007O3-PY for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rxh47-0004h2-8L for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:47:06 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:43189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxh46-0004gO-M7 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:46:43 -0500 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Feb 2012 21:16:39 +0530 Received: from d28relay03.in.ibm.com (9.184.220.60) by e28smtp05.in.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 15 Feb 2012 21:16:36 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1FFka804505622 for ; Wed, 15 Feb 2012 21:16:36 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1FFkZJe025519 for ; Thu, 16 Feb 2012 02:46:35 +1100 Received: from harshbora.in.ibm.com ([9.124.217.190]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q1FFkP3X024759; Thu, 16 Feb 2012 02:46:32 +1100 From: Harsh Prateek Bora To: qemu-devel@nongnu.org Date: Wed, 15 Feb 2012 21:16:21 +0530 Message-Id: <1329320783-6365-13-git-send-email-harsh@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <1329320783-6365-1-git-send-email-harsh@linux.vnet.ibm.com> References: <1329320783-6365-1-git-send-email-harsh@linux.vnet.ibm.com> x-cbid: 12021515-8256-0000-0000-000001451FD3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 122.248.162.5 Cc: stefanha@gmail.com, vilanova@ac.upc.edu, aneesh.kumar@linux.vnet.ibm.com Subject: [Qemu-devel] [RFC PATCH v4 12/14] monitor: remove unused do_info_trace X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: "This command is only available from the human monitor. It's not very useful because it historically hasn't been able to pretty-print events or show them in the right order (we use a ringbuffer but it prints them out from index 0). Therefore, I don't think we're under any obligation to keep this command around. No one has complained about it's limitations - I think this is a sign that no one has used it. I'd be okay with a patch that removes it." Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html Signed-off-by: Harsh Prateek Bora --- monitor.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/monitor.c b/monitor.c index ffda0fe..365ce47 100644 --- a/monitor.c +++ b/monitor.c @@ -942,13 +942,6 @@ static void do_info_cpu_stats(Monitor *mon) } #endif -#if defined(CONFIG_TRACE_SIMPLE) -static void do_info_trace(Monitor *mon) -{ - st_print_trace((FILE *)mon, &monitor_fprintf); -} -#endif - static void do_trace_print_events(Monitor *mon) { trace_print_events((FILE *)mon, &monitor_fprintf); @@ -3033,15 +3026,6 @@ static const mon_cmd_t info_cmds[] = { .help = "show roms", .mhandler.info = do_info_roms, }, -#if defined(CONFIG_TRACE_SIMPLE) - { - .name = "trace", - .args_type = "", - .params = "", - .help = "show current contents of trace buffer", - .mhandler.info = do_info_trace, - }, -#endif { .name = "trace-events", .args_type = "",