From patchwork Mon Nov 21 13:36:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohan Kumar M X-Patchwork-Id: 126817 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D1CE8B720B for ; Tue, 22 Nov 2011 02:18:24 +1100 (EST) Received: from localhost ([::1]:50560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSU4P-0002Ub-Q9 for incoming@patchwork.ozlabs.org; Mon, 21 Nov 2011 08:38:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSU3I-0008RG-BD for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSU3B-0008TE-AU for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:36:52 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:51847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSU3A-0008Qw-DO for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:36:45 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Nov 2011 14:30:42 +1000 Received: from d23relay04.au.ibm.com ([202.81.31.246]) by e23smtp09.au.ibm.com ([202.81.31.206]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 21 Nov 2011 14:30:40 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pALDXGiO3362934 for ; Tue, 22 Nov 2011 00:33:16 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pALDaUJB005607 for ; Tue, 22 Nov 2011 00:36:30 +1100 Received: from explorer.in.ibm.com (explorer.in.ibm.com [9.122.21.115]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pALDaGuC004347; Tue, 22 Nov 2011 00:36:28 +1100 From: "M. Mohan Kumar" To: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com, stefanha@gmail.com, berrange@redhat.com Date: Mon, 21 Nov 2011 19:06:13 +0530 Message-Id: <1321882578-7498-9-git-send-email-mohan@in.ibm.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1321882578-7498-1-git-send-email-mohan@in.ibm.com> References: <1321882578-7498-1-git-send-email-mohan@in.ibm.com> x-cbid: 11112104-3568-0000-0000-000000C191B2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.81.31.142 Cc: "M. Mohan Kumar" Subject: [Qemu-devel] [PATCH V3 08/13] hw/9pfs: File ownership and others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "M. Mohan Kumar" Add file ownership interfaces like chmod/chown, utime update, rename, remove and truncating files for proxy FS Signed-off-by: M. Mohan Kumar --- Makefile | 2 +- fsdev/virtfs-proxy-helper.c | 88 +++++++++++++++++++++++++ hw/9pfs/virtio-9p-proxy.c | 148 +++++++++++++++++++++++++++++++++++++++---- hw/9pfs/virtio-9p-proxy.h | 6 ++ 4 files changed, 231 insertions(+), 13 deletions(-) diff --git a/Makefile b/Makefile index 19b481a..378ee4d 100644 --- a/Makefile +++ b/Makefile @@ -153,7 +153,7 @@ qemu-img$(EXESUF): qemu-img.o $(tools-obj-y) $(block-obj-y) qemu-nbd$(EXESUF): qemu-nbd.o $(tools-obj-y) $(block-obj-y) qemu-io$(EXESUF): qemu-io.o cmd.o $(tools-obj-y) $(block-obj-y) -fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o +fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o oslib-posix.o fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index 7510827..c11538c 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -535,6 +535,9 @@ static void usage(char *prog) static int process_requests(int sock) { + uint64_t offset; + int mode, uid, gid; + struct timespec spec[2]; int type, retval = 0; V9fsString oldpath, path; struct iovec in_iovec, out_iovec; @@ -579,6 +582,85 @@ static int process_requests(int sock) case T_READLINK: size = do_readlink(&in_iovec, &out_iovec); break; + case T_CHMOD: + retval = proxy_unmarshal(&in_iovec, 1, HDR_SZ, "sd", &path, &mode); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = chmod(path.data, mode); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&path); + break; + case T_CHOWN: + retval = proxy_unmarshal(&in_iovec, 1, HDR_SZ, "sdd", &path, + &uid, &gid); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = lchown(path.data, uid, gid); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&path); + break; + case T_TRUNCATE: + retval = proxy_unmarshal(&in_iovec, 1, HDR_SZ, "sq", + &path, &offset); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = truncate(path.data, offset); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&path); + break; + case T_UTIME: + retval = proxy_unmarshal(&in_iovec, 1, HDR_SZ, "sqqqq", &path, + &spec[0].tv_sec, &spec[0].tv_nsec, + &spec[1].tv_sec, &spec[1].tv_nsec); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = qemu_utimensat(AT_FDCWD, path.data, spec, + AT_SYMLINK_NOFOLLOW); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&path); + break; + case T_RENAME: + retval = proxy_unmarshal(&in_iovec, 1, + HDR_SZ, "ss", &oldpath, &path); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = rename(oldpath.data, path.data); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&oldpath); + v9fs_string_free(&path); + break; + case T_REMOVE: + retval = proxy_unmarshal(&in_iovec, 1, HDR_SZ, "s", &path); + if (retval < 0) { + retval = -EOVERFLOW; + break; + } + retval = remove(path.data); + if (retval < 0) { + retval = -errno; + } + v9fs_string_free(&path); + break; default: goto error; break; @@ -593,6 +675,12 @@ static int process_requests(int sock) case T_MKDIR: case T_SYMLINK: case T_LINK: + case T_CHMOD: + case T_CHOWN: + case T_TRUNCATE: + case T_UTIME: + case T_RENAME: + case T_REMOVE: send_status(sock, &out_iovec, retval); break; case T_LSTAT: diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index aca799e..186d681 100644 --- a/hw/9pfs/virtio-9p-proxy.c +++ b/hw/9pfs/virtio-9p-proxy.c @@ -246,6 +246,8 @@ static int v9fs_request(V9fsProxy *proxy, int type, struct iovec *iovec = NULL, *reply = NULL; dev_t rdev; int size = 0; + struct timespec spec[2]; + uint64_t offset; qemu_mutex_lock(&proxy->mutex); @@ -368,6 +370,77 @@ static int v9fs_request(V9fsProxy *proxy, int type, proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); header.size += HDR_SZ; break; + case T_CHMOD: + path = va_arg(ap, V9fsString *); + mode = va_arg(ap, int); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "sd", path, mode); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_CHMOD; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; + case T_CHOWN: + path = va_arg(ap, V9fsString *); + uid = va_arg(ap, int); + gid = va_arg(ap, int); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "sdd", path, uid, gid); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_CHOWN; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; + case T_TRUNCATE: + path = va_arg(ap, V9fsString *); + offset = va_arg(ap, uint64_t); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "sq", path, offset); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_TRUNCATE; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; + case T_UTIME: + path = va_arg(ap, V9fsString *); + spec[0].tv_sec = va_arg(ap, long); + spec[0].tv_nsec = va_arg(ap, long); + spec[1].tv_sec = va_arg(ap, long); + spec[1].tv_nsec = va_arg(ap, long); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "sqqqq", path, + spec[0].tv_sec, spec[1].tv_nsec, + spec[1].tv_sec, spec[1].tv_nsec); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_UTIME; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; + case T_RENAME: + oldpath = va_arg(ap, V9fsString *); + path = va_arg(ap, V9fsString *); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "ss", oldpath, path); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_RENAME; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; + case T_REMOVE: + path = va_arg(ap, V9fsString *); + header.size = proxy_marshal(iovec, 1, HDR_SZ, "s", path); + if (header.size < 0) { + goto out_overflow; + } + header.type = T_REMOVE; + proxy_marshal(iovec, 1, 0, "dd", header.type, header.size); + header.size += HDR_SZ; + break; default: error_report("Invalid type %d\n", type); va_end(ap); @@ -397,6 +470,12 @@ static int v9fs_request(V9fsProxy *proxy, int type, case T_MKDIR: case T_SYMLINK: case T_LINK: + case T_CHMOD: + case T_CHOWN: + case T_RENAME: + case T_TRUNCATE: + case T_UTIME: + case T_REMOVE: retval = v9fs_receive_status(proxy, &sock_error, reply); if (sock_error) { goto close_error; @@ -561,8 +640,13 @@ static ssize_t proxy_pwritev(FsContext *ctx, V9fsFidOpenState *fs, static int proxy_chmod(FsContext *fs_ctx, V9fsPath *fs_path, FsCred *credp) { - errno = EOPNOTSUPP; - return -1; + int retval; + retval = v9fs_request(fs_ctx->private, T_CHMOD, NULL, "sd", + fs_path, credp->fc_mode); + if (retval < 0) { + errno = -retval; + } + return retval; } static int proxy_mknod(FsContext *fs_ctx, V9fsPath *dir_path, @@ -674,34 +758,74 @@ static int proxy_link(FsContext *ctx, V9fsPath *oldpath, static int proxy_truncate(FsContext *ctx, V9fsPath *fs_path, off_t size) { - errno = EOPNOTSUPP; - return -1; + int retval; + + retval = v9fs_request(ctx->private, T_TRUNCATE, NULL, "sq", fs_path, size); + if (retval < 0) { + errno = -retval; + return -1; + } + return 0; } static int proxy_rename(FsContext *ctx, const char *oldpath, const char *newpath) { - errno = EOPNOTSUPP; - return -1; + int retval; + V9fsString oldname, newname; + + v9fs_string_init(&oldname); + v9fs_string_init(&newname); + + v9fs_string_sprintf(&oldname, "%s", oldpath); + v9fs_string_sprintf(&newname, "%s", newpath); + retval = v9fs_request(ctx->private, T_RENAME, NULL, "ss", + &oldname, &newname); + v9fs_string_free(&oldname); + v9fs_string_free(&newname); + if (retval < 0) { + errno = -retval; + } + return retval; } static int proxy_chown(FsContext *fs_ctx, V9fsPath *fs_path, FsCred *credp) { - errno = EOPNOTSUPP; - return -1; + int retval; + retval = v9fs_request(fs_ctx->private, T_CHOWN, NULL, "sdd", + fs_path, credp->fc_uid, credp->fc_gid); + if (retval < 0) { + errno = -retval; + } + return retval; } static int proxy_utimensat(FsContext *s, V9fsPath *fs_path, const struct timespec *buf) { - errno = EOPNOTSUPP; - return -1; + int retval; + retval = v9fs_request(s->private, T_UTIME, NULL, "sqqqq", + fs_path, + buf[0].tv_sec, buf[0].tv_nsec, + buf[1].tv_sec, buf[1].tv_nsec); + if (retval < 0) { + errno = -retval; + } + return retval; } static int proxy_remove(FsContext *ctx, const char *path) { - errno = EOPNOTSUPP; - return -1; + int retval; + V9fsString name; + v9fs_string_init(&name); + v9fs_string_sprintf(&name, "%s", path); + retval = v9fs_request(ctx->private, T_REMOVE, NULL, "s", &name); + v9fs_string_free(&name); + if (retval < 0) { + errno = -retval; + } + return retval; } static int proxy_fsync(FsContext *ctx, V9fsFidOpenState *fs, int datasync) diff --git a/hw/9pfs/virtio-9p-proxy.h b/hw/9pfs/virtio-9p-proxy.h index 4d8dcc2..6a95e9c 100644 --- a/hw/9pfs/virtio-9p-proxy.h +++ b/hw/9pfs/virtio-9p-proxy.h @@ -33,6 +33,12 @@ enum { T_LSTAT, T_READLINK, T_STATFS, + T_CHMOD, + T_CHOWN, + T_TRUNCATE, + T_UTIME, + T_RENAME, + T_REMOVE, }; typedef struct {