| Message ID | 1320429404-3796-1-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
On 4 November 2011 17:56, Andreas Färber <afaerber@suse.de> wrote: > --- a/vl.c > +++ b/vl.c > @@ -1484,7 +1484,7 @@ static void main_loop(void) > > static void version(void) > { > - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); > + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); > } linux-user/main.c:handle_arg_version() needs to be updated too. (Perhaps we should have a QEMU_COPYRIGHT_DATE autoupdated by configure based on the commit date of HEAD? :-)) -- PMM
Am 04.11.2011 18:59, schrieb Peter Maydell: > On 4 November 2011 17:56, Andreas Färber <afaerber@suse.de> wrote: >> --- a/vl.c >> +++ b/vl.c >> @@ -1484,7 +1484,7 @@ static void main_loop(void) >> >> static void version(void) >> { >> - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); >> + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); >> } > > linux-user/main.c:handle_arg_version() needs to be updated too. Thanks for noticing. Me, I'm rather wondering about whether the formulation is right. (IANAL) An alternative would be to leave "Copyright (c) 2003-08 Fabrice" and to add ", Copyright (c) 200x-11 whatever". Andreas
Gerd just reminded me that we did ship 1.0 with a 2008 copyright notice. Am 04.11.2011 18:56, schrieb Andreas Färber: > Judging by -version output, one could get the impression that QEMU was > last modified in 2008. Therefore extend the copyright statement to > cover other contributors so that it can be updated to the current year. > > Signed-off-by: Andreas Färber <afaerber@suse.de> Is my text change okay, so that I should extend the patch to cover *-user as pointed out by Peter? Or is the change a no-go for legal or libvirt reasons? An alternative mentioned in this thread was: Copyright (c) 2003-2008 Fabrice Bellard, Copyright (c) 200x-2011 s.o. The former was intended as a short-term fix for 1.0. I would prefer the latter mid-term since Fabrice doesn't hold any copyright/IPR in the code after he left, but what year and what someone? Opinions please, Andreas > --- > vl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index 624da0f..47e0ae0 100644 > --- a/vl.c > +++ b/vl.c > @@ -1484,7 +1484,7 @@ static void main_loop(void) > > static void version(void) > { > - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); > + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); > } > > static void help(int exitcode)
My suggestion is to put (c) 2003-2011 Fabrice and contributors until we have a foundation and then put (c) 2003-201x qemu foundation. Fabrice by the european copyright laws still have copyright and ipr in any code he generated whatever we have changed as per the "multiple contributors" section of the european laws. (that is unless we did a svn/git delete file.c if that file was started, or based on one started, by Fabrice, it's still partly (c) Fabrice even if no single line remains of his code) El 02/12/2011, a las 15:11, Andreas Färber escribió: > Gerd just reminded me that we did ship 1.0 with a 2008 copyright notice. > > Am 04.11.2011 18:56, schrieb Andreas Färber: >> Judging by -version output, one could get the impression that QEMU was >> last modified in 2008. Therefore extend the copyright statement to >> cover other contributors so that it can be updated to the current year. >> >> Signed-off-by: Andreas Färber <afaerber@suse.de> > > Is my text change okay, so that I should extend the patch to cover > *-user as pointed out by Peter? Or is the change a no-go for legal or > libvirt reasons? > > An alternative mentioned in this thread was: > Copyright (c) 2003-2008 Fabrice Bellard, Copyright (c) 200x-2011 s.o. > > The former was intended as a short-term fix for 1.0. > I would prefer the latter mid-term since Fabrice doesn't hold any > copyright/IPR in the code after he left, but what year and what someone? > > Opinions please, > > Andreas > >> --- >> vl.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index 624da0f..47e0ae0 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -1484,7 +1484,7 @@ static void main_loop(void) >> >> static void version(void) >> { >> - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); >> + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); >> } >> >> static void help(int exitcode) > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
Thanks for your comment. >>> Copyright (c) 2003-2011 Fabrice Bellard and contributors >> Copyright (c) 2003-2008 Fabrice Bellard, Copyright (c) 200x-2011 s.o. Am 02.12.2011 16:25, schrieb Natalia Portillo: > Fabrice by the european copyright laws still have copyright and ipr in any code he generated whatever we have changed as per the "multiple contributors" section of the european laws. No one suggested removing his copyright. But to my understanding Fabrice has no 2009+ copyright on derived works. That's why the copyright wasn't updated all those years, I guess. Andreas > El 02/12/2011, a las 15:11, Andreas Färber escribió: > >> Gerd just reminded me that we did ship 1.0 with a 2008 copyright notice. >> >> Am 04.11.2011 18:56, schrieb Andreas Färber: >>> Judging by -version output, one could get the impression that QEMU was >>> last modified in 2008. Therefore extend the copyright statement to >>> cover other contributors so that it can be updated to the current year. >>> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >> >> Is my text change okay, so that I should extend the patch to cover >> *-user as pointed out by Peter? Or is the change a no-go for legal or >> libvirt reasons? >> >> An alternative mentioned in this thread was: >> Copyright (c) 2003-2008 Fabrice Bellard, Copyright (c) 200x-2011 s.o. >> >> The former was intended as a short-term fix for 1.0. >> I would prefer the latter mid-term since Fabrice doesn't hold any >> copyright/IPR in the code after he left, but what year and what someone? >> >> Opinions please, >> >> Andreas >> >>> --- >>> vl.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/vl.c b/vl.c >>> index 624da0f..47e0ae0 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -1484,7 +1484,7 @@ static void main_loop(void) >>> >>> static void version(void) >>> { >>> - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); >>> + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); >>> } >>> >>> static void help(int exitcode)
diff --git a/vl.c b/vl.c index 624da0f..47e0ae0 100644 --- a/vl.c +++ b/vl.c @@ -1484,7 +1484,7 @@ static void main_loop(void) static void version(void) { - printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2008 Fabrice Bellard\n"); + printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", Copyright (c) 2003-2011 Fabrice Bellard and contributors\n"); } static void help(int exitcode)
Judging by -version output, one could get the impression that QEMU was last modified in 2008. Therefore extend the copyright statement to cover other contributors so that it can be updated to the current year. Signed-off-by: Andreas Färber <afaerber@suse.de> --- vl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)