From patchwork Fri Nov 4 01:03:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 123554 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 19444B6F7F for ; Fri, 4 Nov 2011 12:51:27 +1100 (EST) Received: from localhost ([::1]:60960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM8Ck-0001r4-14 for incoming@patchwork.ozlabs.org; Thu, 03 Nov 2011 21:04:22 -0400 Received: from eggs.gnu.org ([140.186.70.92]:60254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM8CE-0000P3-Tw for qemu-devel@nongnu.org; Thu, 03 Nov 2011 21:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RM8CB-0004K9-A1 for qemu-devel@nongnu.org; Thu, 03 Nov 2011 21:03:50 -0400 Received: from ozlabs.org ([203.10.76.45]:50589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM8CA-0004Jl-Tv for qemu-devel@nongnu.org; Thu, 03 Nov 2011 21:03:47 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 0824DB6F9B; Fri, 4 Nov 2011 12:03:43 +1100 (EST) From: David Gibson To: anthony@codemonkey.ws Date: Fri, 4 Nov 2011 12:03:36 +1100 Message-Id: <1320368618-22733-6-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1320368618-22733-1-git-send-email-david@gibson.dropbear.id.au> References: <1320368618-22733-1-git-send-email-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 203.10.76.45 Cc: joerg.roedel@amd.com, agraf@suse.de, qemu-devel@nongnu.org, avi@redhat.com, eduard.munteanu@linux360.ro, sw@weilnetz.de, rth@twiddle.net Subject: [Qemu-devel] [PATCH 5/7] Remove unnecessary casts from PCI DMA code in rtl8139 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch removes some unnecessary casts in the rtl8139 device, introduced by commit 3ada003aee2004d24f23b9cd6f4eda87d9601ddb 'rtl8139: Use PCI DMA stub functions'. Signed-off-by: David Gibson --- hw/rtl8139.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 4c37993..30a7eb6 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -991,13 +991,13 @@ static ssize_t rtl8139_do_receive(VLANClientState *nc, const uint8_t *buf, size_ uint32_t val, rxdw0,rxdw1,rxbufLO,rxbufHI; - pci_dma_read(&s->dev, cplus_rx_ring_desc, (uint8_t *)&val, 4); + pci_dma_read(&s->dev, cplus_rx_ring_desc, &val, 4); rxdw0 = le32_to_cpu(val); - pci_dma_read(&s->dev, cplus_rx_ring_desc+4, (uint8_t *)&val, 4); + pci_dma_read(&s->dev, cplus_rx_ring_desc+4, &val, 4); rxdw1 = le32_to_cpu(val); - pci_dma_read(&s->dev, cplus_rx_ring_desc+8, (uint8_t *)&val, 4); + pci_dma_read(&s->dev, cplus_rx_ring_desc+8, &val, 4); rxbufLO = le32_to_cpu(val); - pci_dma_read(&s->dev, cplus_rx_ring_desc+12, (uint8_t *)&val, 4); + pci_dma_read(&s->dev, cplus_rx_ring_desc+12, &val, 4); rxbufHI = le32_to_cpu(val); DPRINTF("+++ C+ mode RX descriptor %d %08x %08x %08x %08x\n",