From patchwork Sat Sep 17 18:51:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 115157 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CD53FB7010 for ; Sun, 18 Sep 2011 04:52:08 +1000 (EST) Received: from localhost ([::1]:44697 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4zzi-0005VJ-5a for incoming@patchwork.ozlabs.org; Sat, 17 Sep 2011 14:52:06 -0400 Received: from eggs.gnu.org ([140.186.70.92]:47516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4zzb-0005Uv-Vw for qemu-devel@nongnu.org; Sat, 17 Sep 2011 14:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4zza-0007b9-Q7 for qemu-devel@nongnu.org; Sat, 17 Sep 2011 14:51:59 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:56385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4zza-0007ad-Jy for qemu-devel@nongnu.org; Sat, 17 Sep 2011 14:51:58 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1R4zzR-0001Lr-Ki; Sat, 17 Sep 2011 19:51:49 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Sat, 17 Sep 2011 19:51:49 +0100 Message-Id: <1316285509-5170-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1316285509-5170-1-git-send-email-peter.maydell@linaro.org> References: <1316285509-5170-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 81.2.115.146 Cc: patches@linaro.org Subject: [Qemu-devel] [PATCH 2/2] hw/omap_gpmc: Modify correct field when writing IRQSTATUS register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Writing to IRQSTATUS should affect irqst, not irqen -- error spotted by Andrzej Zaborowski. Signed-off-by: Peter Maydell --- hw/omap_gpmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index e27b93c..7fc82a2 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -639,7 +639,7 @@ static void omap_gpmc_write(void *opaque, target_phys_addr_t addr, break; case 0x018: /* GPMC_IRQSTATUS */ - s->irqen &= ~value; + s->irqst &= ~value; omap_gpmc_int_update(s); break;