| Message ID | 1312663642-8298-1-git-send-email-weil@mail.berlios.de |
|---|---|
| State | Accepted |
| Headers | show |
Am 06.08.2011 22:47, schrieb Stefan Weil: > guest_agent is not supported for mingw32, so the default value > should be 'no', not 'yes'. > > This removes the dependencies to glib-2.0 and python which > makes native and cross builds for w32 much easier (no need > to get and install these extra packages). > > It also avoids the problems caused by different bitfield alignment > which is required by glib-2.0. > > It is still possible to set guest_agent=yes via configure option. > > Signed-off-by: Stefan Weil<weil@mail.berlios.de> > --- > configure | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 0c67a4a..4cb33d9 100755 > --- a/configure > +++ b/configure > @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then > bindir="\${prefix}" > sysconfdir="\${prefix}" > confsuffix="" > + guest_agent="no" > fi > > werror="" > Please apply this patch (or a similar solution) to QEMU 0.15, too. Otherwise QEMU 0.15 won't be usable with w32 (slirp bitfields). Thanks, Stefan Weil
On 08/06/2011 03:47 PM, Stefan Weil wrote: > guest_agent is not supported for mingw32, so the default value > should be 'no', not 'yes'. Why is it not supported? It should build just fine. If the answer is, -mms-bitfield, then we should fix slirp instead of disabling guest-agent. Regards, Anthony Liguori > > This removes the dependencies to glib-2.0 and python which > makes native and cross builds for w32 much easier (no need > to get and install these extra packages). > > It also avoids the problems caused by different bitfield alignment > which is required by glib-2.0. > > It is still possible to set guest_agent=yes via configure option. > > Signed-off-by: Stefan Weil<weil@mail.berlios.de> > --- > configure | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 0c67a4a..4cb33d9 100755 > --- a/configure > +++ b/configure > @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then > bindir="\${prefix}" > sysconfdir="\${prefix}" > confsuffix="" > + guest_agent="no" > fi > > werror=""
Am 07.08.2011 17:50, schrieb Anthony Liguori: > On 08/06/2011 03:47 PM, Stefan Weil wrote: >> guest_agent is not supported for mingw32, so the default value >> should be 'no', not 'yes'. > > Why is it not supported? It should build just fine. > > If the answer is, -mms-bitfield, then we should fix slirp instead of > disabling guest-agent. > > Regards, > > Anthony Liguori Code extract from configure: if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) $tools" if [ "$guest_agent" = "yes" ]; then tools="qemu-ga\$(EXESUF) $tools" fi if [ "$check_utests" = "yes" ]; then tools="check-qint check-qstring check-qdict check-qlist $tools" tools="check-qfloat check-qjson $tools" fi fi MinGW32 is neither linux nor bsd nor solaris, so guest_agent="yes" won't enable qemu-ga.exe. Of course this (and the bitfield related problems) should be fixed in git master, but not in stable-0.15. So for 0.15, the patch is a must (unless you are prepared to take additional patches for the bitfield issues). Even for git master, the patch is reasonable because it allows QEMU builds with most mingw32 installations. As soon as there is a w32 QEMU working with glib-2.0 and a w32 qemu-ga.exe (and some documentation in the QEMU wiki how to get glib-2.0 and python), the patch can be reverted. Regards, Stefan Weil
On 08/06/2011 03:47 PM, Stefan Weil wrote: > guest_agent is not supported for mingw32, so the default value > should be 'no', not 'yes'. > > This removes the dependencies to glib-2.0 and python which > makes native and cross builds for w32 much easier (no need > to get and install these extra packages). > > It also avoids the problems caused by different bitfield alignment > which is required by glib-2.0. > > It is still possible to set guest_agent=yes via configure option. > > Signed-off-by: Stefan Weil<weil@mail.berlios.de> This came in too late to make 0.15.0. I'd consider applying this to the stable branch but I'd really prefer we fix the slirp packing issue directly. Regards, Anthony Liguori > --- > configure | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 0c67a4a..4cb33d9 100755 > --- a/configure > +++ b/configure > @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then > bindir="\${prefix}" > sysconfdir="\${prefix}" > confsuffix="" > + guest_agent="no" > fi > > werror=""
On 08/06/2011 03:47 PM, Stefan Weil wrote: > guest_agent is not supported for mingw32, so the default value > should be 'no', not 'yes'. > > This removes the dependencies to glib-2.0 and python which > makes native and cross builds for w32 much easier (no need > to get and install these extra packages). > > It also avoids the problems caused by different bitfield alignment > which is required by glib-2.0. > > It is still possible to set guest_agent=yes via configure option. > > Signed-off-by: Stefan Weil<weil@mail.berlios.de> Applied to master with the expectation that we will still properly fix the slirp packing issue. Regards, Anthony Liguori > --- > configure | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 0c67a4a..4cb33d9 100755 > --- a/configure > +++ b/configure > @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then > bindir="\${prefix}" > sysconfdir="\${prefix}" > confsuffix="" > + guest_agent="no" > fi > > werror=""
diff --git a/configure b/configure index 0c67a4a..4cb33d9 100755 --- a/configure +++ b/configure @@ -493,6 +493,7 @@ if test "$mingw32" = "yes" ; then bindir="\${prefix}" sysconfdir="\${prefix}" confsuffix="" + guest_agent="no" fi werror=""
guest_agent is not supported for mingw32, so the default value should be 'no', not 'yes'. This removes the dependencies to glib-2.0 and python which makes native and cross builds for w32 much easier (no need to get and install these extra packages). It also avoids the problems caused by different bitfield alignment which is required by glib-2.0. It is still possible to set guest_agent=yes via configure option. Signed-off-by: Stefan Weil <weil@mail.berlios.de> --- configure | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)