From patchwork Fri Jul 15 19:38:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 104885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5C821B6F54 for ; Sat, 16 Jul 2011 05:50:19 +1000 (EST) Received: from localhost ([::1]:56581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhoOu-0000Mf-3h for incoming@patchwork.ozlabs.org; Fri, 15 Jul 2011 15:50:16 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhoDz-0006ua-V2 for qemu-devel@nongnu.org; Fri, 15 Jul 2011 15:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhoDv-0003H6-Lt for qemu-devel@nongnu.org; Fri, 15 Jul 2011 15:38:59 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:50075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhoDv-0003Gt-72 for qemu-devel@nongnu.org; Fri, 15 Jul 2011 15:38:55 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 7398C7282F64; Fri, 15 Jul 2011 21:38:54 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8ORYXMZmhhtS; Fri, 15 Jul 2011 21:38:50 +0200 (CEST) Received: from flocke.weilnetz.de (p5086FFA4.dip.t-dialin.net [80.134.255.164]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 055607282F5E; Fri, 15 Jul 2011 21:38:50 +0200 (CEST) Received: from stefan by flocke.weilnetz.de with local (Exim 4.72) (envelope-from ) id 1QhoDp-0001hy-93; Fri, 15 Jul 2011 21:38:49 +0200 From: Stefan Weil To: Blue Swirl Date: Fri, 15 Jul 2011 21:38:14 +0200 Message-Id: <1310758694-6360-4-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1310758694-6360-1-git-send-email-weil@mail.berlios.de> References: <1310758694-6360-1-git-send-email-weil@mail.berlios.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 78.47.199.172 Cc: QEMU Developers Subject: [Qemu-devel] [PATCH 3/3] w32: Fix format string regression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Commit 953ffe0f935f40c0d6061d69e76e0339393b54f8 introduced FMT_pid which is wrong for w32 and w64 getpid(): those getpid() implementations always return an int value. Signed-off-by: Stefan Weil --- os-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-win32.c b/os-win32.c index b6652af..e153058 100644 --- a/os-win32.c +++ b/os-win32.c @@ -258,7 +258,7 @@ int qemu_create_pidfile(const char *filename) if (file == INVALID_HANDLE_VALUE) { return -1; } - len = snprintf(buffer, sizeof(buffer), FMT_pid "\n", getpid()); + len = snprintf(buffer, sizeof(buffer), "%d\n", getpid()); ret = WriteFileEx(file, (LPCVOID)buffer, (DWORD)len, &overlap, NULL); if (ret == 0) {