From patchwork Wed Jun 29 11:57:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 102573 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5C1CFB6F59 for ; Wed, 29 Jun 2011 22:02:30 +1000 (EST) Received: from localhost ([::1]:41584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbtTO-0004fl-E9 for incoming@patchwork.ozlabs.org; Wed, 29 Jun 2011 08:02:26 -0400 Received: from eggs.gnu.org ([140.186.70.92]:53942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbtOe-0004M1-Px for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbtOd-0006zw-EQ for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:57:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbtOc-0006zm-Q4 for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:57:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TBvURa029147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 07:57:30 -0400 Received: from bow.redhat.com (vpn-11-114.rdu.redhat.com [10.11.11.114]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5TBvOFL002457; Wed, 29 Jun 2011 07:57:28 -0400 From: Alon Levy To: qemu-devel@nongnu.org Date: Wed, 29 Jun 2011 13:57:08 +0200 Message-Id: <1309348641-20061-3-git-send-email-alevy@redhat.com> In-Reply-To: <1309348641-20061-1-git-send-email-alevy@redhat.com> References: <1309348641-20061-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: yhalperi@redhat.com, kraxel@redhat.com Subject: [Qemu-devel] [PATCHv3] async thread fix - handle EAGAIN/EINTR, remove fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org --- hw/qxl.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 89e452e..3f84b0c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1025,13 +1025,15 @@ static void *ioport_write_async(void *arg) while (true) { ret = read(d->aio_pipe[0], &io, sizeof(io)); + if (ret < 0 && (errno == EAGAIN || errno == EINTR)) { + continue; + } if (ret != sizeof(io)) { break; } io_port = io->port; val = io->val; - fprintf(stderr, "%s: 0x%x\n", __FUNCTION__, io_port); switch (io_port) { case QXL_IO_UPDATE_AREA_ASYNC: qxl_spice_update_area(d, io->update_surface,