From patchwork Tue May 31 09:39:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 97997 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DD81FB6F6C for ; Tue, 31 May 2011 19:40:43 +1000 (EST) Received: from localhost ([::1]:38882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLRI-0008Lv-3S for incoming@patchwork.ozlabs.org; Tue, 31 May 2011 05:40:40 -0400 Received: from eggs.gnu.org ([140.186.70.92]:48436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLQD-0006GB-Vp for qemu-devel@nongnu.org; Tue, 31 May 2011 05:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRLQD-0003Nc-4B for qemu-devel@nongnu.org; Tue, 31 May 2011 05:39:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRLQC-0003NP-Sl for qemu-devel@nongnu.org; Tue, 31 May 2011 05:39:33 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4V9dWxd024576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 31 May 2011 05:39:32 -0400 Received: from shalem.localdomain.com (vpn1-4-207.ams2.redhat.com [10.36.4.207]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4V9dSsC003893; Tue, 31 May 2011 05:39:31 -0400 From: Hans de Goede To: qemu-devel@nongnu.org Date: Tue, 31 May 2011 11:39:41 +0200 Message-Id: <1306834783-13070-3-git-send-email-hdegoede@redhat.com> In-Reply-To: <1306834783-13070-1-git-send-email-hdegoede@redhat.com> References: <1306834783-13070-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede Subject: [Qemu-devel] [PATCH 2/4] usb-bus: Don't allow speed mismatch while attaching devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org --- hw/usb-bus.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 2ae2678..1817d5c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -200,6 +200,11 @@ static int do_attach(USBDevice *dev) } else { port = QTAILQ_FIRST(&bus->free); } + if (!(port->speedmask & dev->speedmask)) { + fprintf(stderr, "Warning: speed mismatch trying to attach usb device %s to bus %s\n", + dev->product_desc, bus->qbus.name); + return -1; + } dev->attached++; QTAILQ_REMOVE(&bus->free, port, next);