diff mbox

[08/14] usb-linux: Don't try to open the same device twice

Message ID 1306834530-12763-9-git-send-email-hdegoede@redhat.com
State New
Headers show

Commit Message

Hans de Goede May 31, 2011, 9:35 a.m. UTC 
If a user wants to redirect 2 identical usb sticks, in theory this is
possible by doing:
usb_add host:1234:5678
usb_add host:1234:5678

But this will lead to us trying to open the first stick twice, since we
don't break the loop after having found a match in our filter list, so the next'
filter list entry will result in us trying to open the same device again.

Fix this by adding the missing break.
---
 usb-linux.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Gerd Hoffmann June 1, 2011, 12:35 p.m. UTC | #1 
On 05/31/11 11:35, Hans de Goede wrote:
> If a user wants to redirect 2 identical usb sticks, in theory this is
> possible by doing:
> usb_add host:1234:5678
> usb_add host:1234:5678
>
> But this will lead to us trying to open the first stick twice, since we
> don't break the loop after having found a match in our filter list, so the next'
> filter list entry will result in us trying to open the same device again.
>
> Fix

Good catch.

Patch applied.

thanks,
   Gerd
diff mbox

Patch

diff --git a/usb-linux.c b/usb-linux.c
index 334012e..eb9805b 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -1689,6 +1689,7 @@  static int usb_host_auto_scan(void *opaque, int bus_num, int addr, char *port,
                a qdev from its initfn is not allowed. */
             s->open_failed = ret;
         }
+        break;
     }
 
     return 0;