From patchwork Sat May 7 20:44:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 94512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EC9B4B6FD1 for ; Sun, 8 May 2011 06:44:23 +1000 (EST) Received: from localhost ([::1]:54871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIoMO-0007dq-3W for incoming@patchwork.ozlabs.org; Sat, 07 May 2011 16:44:20 -0400 Received: from eggs.gnu.org ([140.186.70.92]:60446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIoMH-0007di-LJ for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIoMG-00071l-O9 for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:13 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:52776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIoMG-00071e-AB for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:12 -0400 Received: from flocke.fritz.box (p54ADACCA.dip.t-dialin.net [84.173.172.202]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0MJIXG-1QLYB60NqM-002kpf; Sat, 07 May 2011 22:44:10 +0200 Received: from stefan by flocke.fritz.box with local (Exim 4.72) (envelope-from ) id 1QIoMD-0006mS-8v; Sat, 07 May 2011 22:44:09 +0200 From: Stefan Weil To: QEMU Developers Date: Sat, 7 May 2011 22:44:08 +0200 Message-Id: <1304801048-26036-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.2.5 X-Provags-ID: V02:K0:yeSvez55A5vjE1jI4R3hp+L4Ivl70zh4nPtK4MYE/nM f+mMSDc0qLwmSd0fsntW1MGU0ZQYTf0T114a9yL7nhD0SUhso2 bVcKwCEZYiZeKkeqKhj8A5He2GQSZwRjjFbKTj0rY1d8MDOBFW ghfPtmvOzC/eQWYgNCUoOG/1HK/NKVkun2iCd614T2g1s7NZ7B /g3+l1867Em4rtsj40lahc50Td7R2aQ0+7Idkg78X18YUEAeEA jiORkUo4Cj/o1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.17.9 Cc: Riku Voipio Subject: [Qemu-devel] [PATCH] linux-user: Set uninitialized local variable and disable unused code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org cppcheck report: linux-user/signal.c:2057: error: Uninitialized variable: err cppcheck is correct. Setting err = 0 is a workaround to avoid random results and the cppcheck warning. Function restore_fpu_state is currently unused, so I disabled the code. Signed-off-by: Stefan Weil --- linux-user/signal.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index ce033e9..4bda475 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2027,6 +2027,8 @@ sigsegv: unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); force_sig(TARGET_SIGSEGV); } + +#if 0 /* TODO: function is unused */ static inline int restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) { @@ -2053,6 +2055,8 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) /* XXX: incorrect */ err = __copy_from_user(&env->fpr[0], &fpu->si_float_regs[0], (sizeof(unsigned long) * 32)); +#else + err = 0; #endif err |= __get_user(env->fsr, &fpu->si_fsr); #if 0 @@ -2065,7 +2069,7 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) #endif return err; } - +#endif static void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info,