diff mbox

[01/18] Fix typos in comments (dependancy -> dependency)

Message ID 1304004042-8334-1-git-send-email-weil@mail.berlios.de
State Accepted
Headers show

Commit Message

Stefan Weil April 28, 2011, 3:20 p.m. UTC
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 Changelog     |    2 +-
 Makefile.objs |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Weil May 3, 2011, 8:25 p.m. UTC | #1
Am 28.04.2011 17:20, schrieb Stefan Weil:
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> Changelog | 2 +-
> Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>

There were no replies to the patch series up to now.

Should I have added a remark that all 18 patches are independent,
so they are trivial even if the series contains more than 4 patches?

Or would it be better to combine all patches in one large patch?
I did not do this because review is a little easier with small
patches, and it also reduces the risk of merge conflicts.

Best regards,

Stefan W.
Stefan Hajnoczi May 4, 2011, 3:18 p.m. UTC | #2
On Tue, May 3, 2011 at 9:25 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 28.04.2011 17:20, schrieb Stefan Weil:
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> Changelog | 2 +-
>> Makefile.objs | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>
> There were no replies to the patch series up to now.

Sorry, I have been away on holiday and am still catching back up.
Let's take them as they are.

Stefan
Stefan Hajnoczi May 8, 2011, noon UTC | #3
On Thu, Apr 28, 2011 at 05:20:25PM +0200, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  Changelog     |    2 +-
>  Makefile.objs |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied the series to the trivial-patches branch:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

For more information see http://wiki.qemu.org/Contribute/TrivialPatches.

Stefan
diff mbox

Patch

diff --git a/Changelog b/Changelog
index 152feaa..1c41e14 100644
--- a/Changelog
+++ b/Changelog
@@ -525,7 +525,7 @@  version 0.1.5:
 
  - ppc64 support + personality() patch (Rusty Russell)
  - first Alpha CPU patches (Falk Hueffner)
- - removed bfd.h dependancy
+ - removed bfd.h dependency
  - fixed shrd, shld, idivl and divl on PowerPC.
  - fixed buggy glibc PowerPC rint() function (test-i386 passes now on PowerPC).
 
diff --git a/Makefile.objs b/Makefile.objs
index 0cbff4d..e387ab9 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -335,7 +335,7 @@  trace-dtrace.h: trace-dtrace.dtrace
 	$(call quiet-command,dtrace -o $@ -h -s $<, "  GEN   trace-dtrace.h")
 
 # Normal practice is to name DTrace probe file with a '.d' extension
-# but that gets picked up by QEMU's Makefile as an external dependancy
+# but that gets picked up by QEMU's Makefile as an external dependency
 # rule file. So we use '.dtrace' instead
 trace-dtrace.dtrace: trace-dtrace.dtrace-timestamp
 trace-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events config-host.mak