From patchwork Sun Feb 20 13:50:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 83740 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 388CCB715A for ; Mon, 21 Feb 2011 01:14:59 +1100 (EST) Received: from localhost ([127.0.0.1]:38062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrA3U-0004vg-B8 for incoming@patchwork.ozlabs.org; Sun, 20 Feb 2011 09:14:32 -0500 Received: from [140.186.70.92] (port=44878 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pr9qd-0006Dq-QY for qemu-devel@nongnu.org; Sun, 20 Feb 2011 09:01:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pr9qc-0002D0-4X for qemu-devel@nongnu.org; Sun, 20 Feb 2011 09:01:15 -0500 Received: from mail-fx0-f45.google.com ([209.85.161.45]:45350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pr9qb-00029G-Rw for qemu-devel@nongnu.org; Sun, 20 Feb 2011 09:01:14 -0500 Received: by mail-fx0-f45.google.com with SMTP id 11so336913fxm.4 for ; Sun, 20 Feb 2011 06:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:message-id:x-mailer :in-reply-to:references; bh=lUY09NYV49pazmpOmjjtTu/4zwrpqUh8uMsYpKYcCJw=; b=UDvTY5iU9tmNgTsMgwfj2UIP9IWo/9uWJXCr2C6WfJBt1wka158sNB/o/YmJlTSCLI C3cabUDVnHbAthHev6PvEr3F8E+g3N8LQGtgXtSUEwjJJ8pWK1LJMvPjQqeCt83spXVV mxjuN9/cmjReiQtCReZznNOOf5REWPS6Dj7GU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; b=TLtsbvqaVaOmQa0wkBN1s737+7pUWqZYHAIXpjR73xWWu2BnjM0rDSP/4Y1uMyZhJA MV8U/be02ffpnlF9y55zQiWrG9uv/eZB2VIkWUBCaTVDnISkjJy4s7ZjoHdyyWrLyyuH jtG2uxJDxXY1O9oERbATFcoRRFW+RR7mJq8Co= Received: by 10.223.74.5 with SMTP id s5mr516738faj.72.1298210473394; Sun, 20 Feb 2011 06:01:13 -0800 (PST) Received: from doriath.ww600.siemens.net (pd95b1e1f.dip0.t-ipconnect.de [217.91.30.31]) by mx.google.com with ESMTPS id n3sm1959971faa.29.2011.02.20.06.00.58 (version=SSLv3 cipher=OTHER); Sun, 20 Feb 2011 06:01:12 -0800 (PST) From: Dmitry Eremin-Solenikov To: qemu-devel@nongnu.org Date: Sun, 20 Feb 2011 16:50:38 +0300 Message-Id: <1298209838-27699-11-git-send-email-dbaryshkov@gmail.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1298209838-27699-1-git-send-email-dbaryshkov@gmail.com> References: <1298209838-27699-1-git-send-email-dbaryshkov@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.45 Subject: [Qemu-devel] [PATCH 10/10] pxa2xx: port pxa2xx_rtc to using qdev/vmstate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa.h | 27 --------- hw/pxa2xx.c | 173 ++++++++++++++++++++++++++++++++++------------------------- 2 files changed, 100 insertions(+), 100 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h index bad0556..6e2509a 100644 --- a/hw/pxa.h +++ b/hw/pxa.h @@ -150,33 +150,6 @@ typedef struct { /* Performance monitoring */ uint32_t pmnc; - /* Real-Time clock */ - target_phys_addr_t rtc_base; - uint32_t rttr; - uint32_t rtsr; - uint32_t rtar; - uint32_t rdar1; - uint32_t rdar2; - uint32_t ryar1; - uint32_t ryar2; - uint32_t swar1; - uint32_t swar2; - uint32_t piar; - uint32_t last_rcnr; - uint32_t last_rdcr; - uint32_t last_rycr; - uint32_t last_swcr; - uint32_t last_rtcpicr; - int64_t last_hz; - int64_t last_sw; - int64_t last_pi; - QEMUTimer *rtc_hz; - QEMUTimer *rtc_rdal1; - QEMUTimer *rtc_rdal2; - QEMUTimer *rtc_swal1; - QEMUTimer *rtc_swal2; - QEMUTimer *rtc_pi; - qemu_irq rtc_irq; } PXA2xxState; struct PXA2xxI2SState { diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index f9ada1c..3607f27 100644 --- a/hw/pxa2xx.c +++ b/hw/pxa2xx.c @@ -13,7 +13,6 @@ #include "pc.h" #include "i2c.h" #include "ssi.h" -#include "qemu-timer.h" #include "qemu-char.h" #include "blockdev.h" #include "arm-misc.h" @@ -887,12 +886,41 @@ static int pxa2xx_ssp_init(SysBusDevice *dev) #define RTCPICR 0x34 /* RTC Periodic Interrupt Counter register */ #define PIAR 0x38 /* RTC Periodic Interrupt Alarm register */ -static inline void pxa2xx_rtc_int_update(PXA2xxState *s) +typedef struct { + SysBusDevice busdev; + uint32_t rttr; + uint32_t rtsr; + uint32_t rtar; + uint32_t rdar1; + uint32_t rdar2; + uint32_t ryar1; + uint32_t ryar2; + uint32_t swar1; + uint32_t swar2; + uint32_t piar; + uint32_t last_rcnr; + uint32_t last_rdcr; + uint32_t last_rycr; + uint32_t last_swcr; + uint32_t last_rtcpicr; + int64_t last_hz; + int64_t last_sw; + int64_t last_pi; + QEMUTimer *rtc_hz; + QEMUTimer *rtc_rdal1; + QEMUTimer *rtc_rdal2; + QEMUTimer *rtc_swal1; + QEMUTimer *rtc_swal2; + QEMUTimer *rtc_pi; + qemu_irq rtc_irq; +} PXA2xxRTCState; + +static inline void pxa2xx_rtc_int_update(PXA2xxRTCState *s) { qemu_set_irq(s->rtc_irq, !!(s->rtsr & 0x2553)); } -static void pxa2xx_rtc_hzupdate(PXA2xxState *s) +static void pxa2xx_rtc_hzupdate(PXA2xxRTCState *s) { int64_t rt = qemu_get_clock(rt_clock); s->last_rcnr += ((rt - s->last_hz) << 15) / @@ -902,7 +930,7 @@ static void pxa2xx_rtc_hzupdate(PXA2xxState *s) s->last_hz = rt; } -static void pxa2xx_rtc_swupdate(PXA2xxState *s) +static void pxa2xx_rtc_swupdate(PXA2xxRTCState *s) { int64_t rt = qemu_get_clock(rt_clock); if (s->rtsr & (1 << 12)) @@ -910,7 +938,7 @@ static void pxa2xx_rtc_swupdate(PXA2xxState *s) s->last_sw = rt; } -static void pxa2xx_rtc_piupdate(PXA2xxState *s) +static void pxa2xx_rtc_piupdate(PXA2xxRTCState *s) { int64_t rt = qemu_get_clock(rt_clock); if (s->rtsr & (1 << 15)) @@ -918,7 +946,7 @@ static void pxa2xx_rtc_piupdate(PXA2xxState *s) s->last_pi = rt; } -static inline void pxa2xx_rtc_alarm_update(PXA2xxState *s, +static inline void pxa2xx_rtc_alarm_update(PXA2xxRTCState *s, uint32_t rtsr) { if ((rtsr & (1 << 2)) && !(rtsr & (1 << 0))) @@ -963,7 +991,7 @@ static inline void pxa2xx_rtc_alarm_update(PXA2xxState *s, static inline void pxa2xx_rtc_hz_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 0); pxa2xx_rtc_alarm_update(s, s->rtsr); pxa2xx_rtc_int_update(s); @@ -971,7 +999,7 @@ static inline void pxa2xx_rtc_hz_tick(void *opaque) static inline void pxa2xx_rtc_rdal1_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 4); pxa2xx_rtc_alarm_update(s, s->rtsr); pxa2xx_rtc_int_update(s); @@ -979,7 +1007,7 @@ static inline void pxa2xx_rtc_rdal1_tick(void *opaque) static inline void pxa2xx_rtc_rdal2_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 6); pxa2xx_rtc_alarm_update(s, s->rtsr); pxa2xx_rtc_int_update(s); @@ -987,7 +1015,7 @@ static inline void pxa2xx_rtc_rdal2_tick(void *opaque) static inline void pxa2xx_rtc_swal1_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 8); pxa2xx_rtc_alarm_update(s, s->rtsr); pxa2xx_rtc_int_update(s); @@ -995,7 +1023,7 @@ static inline void pxa2xx_rtc_swal1_tick(void *opaque) static inline void pxa2xx_rtc_swal2_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 10); pxa2xx_rtc_alarm_update(s, s->rtsr); pxa2xx_rtc_int_update(s); @@ -1003,7 +1031,7 @@ static inline void pxa2xx_rtc_swal2_tick(void *opaque) static inline void pxa2xx_rtc_pi_tick(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; s->rtsr |= (1 << 13); pxa2xx_rtc_piupdate(s); s->last_rtcpicr = 0; @@ -1013,7 +1041,7 @@ static inline void pxa2xx_rtc_pi_tick(void *opaque) static uint32_t pxa2xx_rtc_read(void *opaque, target_phys_addr_t addr) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; switch (addr) { case RTTR: @@ -1059,7 +1087,7 @@ static uint32_t pxa2xx_rtc_read(void *opaque, target_phys_addr_t addr) static void pxa2xx_rtc_write(void *opaque, target_phys_addr_t addr, uint32_t value) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; switch (addr) { case RTTR: @@ -1171,10 +1199,12 @@ static CPUWriteMemoryFunc * const pxa2xx_rtc_writefn[] = { pxa2xx_rtc_write, }; -static void pxa2xx_rtc_init(PXA2xxState *s) +static int pxa2xx_rtc_init(SysBusDevice *dev) { + PXA2xxRTCState *s = FROM_SYSBUS(PXA2xxRTCState, dev); struct tm tm; int wom; + int iomemtype; s->rttr = 0x7fff; s->rtsr = 0; @@ -1199,65 +1229,71 @@ static void pxa2xx_rtc_init(PXA2xxState *s) s->rtc_swal2 = qemu_new_timer(rt_clock, pxa2xx_rtc_swal2_tick, s); s->rtc_pi = qemu_new_timer(rt_clock, pxa2xx_rtc_pi_tick, s); - s->rtc_irq = qdev_get_gpio_in(s->pic, PXA2XX_PIC_RTCALARM); + sysbus_init_irq(dev, &s->rtc_irq); + + iomemtype = cpu_register_io_memory(pxa2xx_rtc_readfn, + pxa2xx_rtc_writefn, s, DEVICE_NATIVE_ENDIAN); + sysbus_init_mmio(dev, 0x10000, iomemtype); + + return 0; } -static void pxa2xx_rtc_save(QEMUFile *f, void *opaque) +static void pxa2xx_rtc_pre_save(void *opaque) { - PXA2xxState *s = (PXA2xxState *) opaque; + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; pxa2xx_rtc_hzupdate(s); pxa2xx_rtc_piupdate(s); pxa2xx_rtc_swupdate(s); +} - qemu_put_be32s(f, &s->rttr); - qemu_put_be32s(f, &s->rtsr); - qemu_put_be32s(f, &s->rtar); - qemu_put_be32s(f, &s->rdar1); - qemu_put_be32s(f, &s->rdar2); - qemu_put_be32s(f, &s->ryar1); - qemu_put_be32s(f, &s->ryar2); - qemu_put_be32s(f, &s->swar1); - qemu_put_be32s(f, &s->swar2); - qemu_put_be32s(f, &s->piar); - qemu_put_be32s(f, &s->last_rcnr); - qemu_put_be32s(f, &s->last_rdcr); - qemu_put_be32s(f, &s->last_rycr); - qemu_put_be32s(f, &s->last_swcr); - qemu_put_be32s(f, &s->last_rtcpicr); - qemu_put_sbe64s(f, &s->last_hz); - qemu_put_sbe64s(f, &s->last_sw); - qemu_put_sbe64s(f, &s->last_pi); -} - -static int pxa2xx_rtc_load(QEMUFile *f, void *opaque, int version_id) +static int pxa2xx_rtc_post_load(void *opaque, int version_id) { - PXA2xxState *s = (PXA2xxState *) opaque; - - qemu_get_be32s(f, &s->rttr); - qemu_get_be32s(f, &s->rtsr); - qemu_get_be32s(f, &s->rtar); - qemu_get_be32s(f, &s->rdar1); - qemu_get_be32s(f, &s->rdar2); - qemu_get_be32s(f, &s->ryar1); - qemu_get_be32s(f, &s->ryar2); - qemu_get_be32s(f, &s->swar1); - qemu_get_be32s(f, &s->swar2); - qemu_get_be32s(f, &s->piar); - qemu_get_be32s(f, &s->last_rcnr); - qemu_get_be32s(f, &s->last_rdcr); - qemu_get_be32s(f, &s->last_rycr); - qemu_get_be32s(f, &s->last_swcr); - qemu_get_be32s(f, &s->last_rtcpicr); - qemu_get_sbe64s(f, &s->last_hz); - qemu_get_sbe64s(f, &s->last_sw); - qemu_get_sbe64s(f, &s->last_pi); + PXA2xxRTCState *s = (PXA2xxRTCState *) opaque; pxa2xx_rtc_alarm_update(s, s->rtsr); return 0; } +static const VMStateDescription vmstate_pxa2xx_rtc_regs = { + .name = "pxa2xx_rtc", + .version_id = 0, + .minimum_version_id = 0, + .minimum_version_id_old = 0, + .pre_save = pxa2xx_rtc_pre_save, + .post_load = pxa2xx_rtc_post_load, + .fields = (VMStateField[]) { + VMSTATE_UINT32(rttr, PXA2xxRTCState), + VMSTATE_UINT32(rtsr, PXA2xxRTCState), + VMSTATE_UINT32(rtar, PXA2xxRTCState), + VMSTATE_UINT32(rdar1, PXA2xxRTCState), + VMSTATE_UINT32(rdar2, PXA2xxRTCState), + VMSTATE_UINT32(ryar1, PXA2xxRTCState), + VMSTATE_UINT32(ryar2, PXA2xxRTCState), + VMSTATE_UINT32(swar1, PXA2xxRTCState), + VMSTATE_UINT32(swar2, PXA2xxRTCState), + VMSTATE_UINT32(piar, PXA2xxRTCState), + VMSTATE_UINT32(last_rcnr, PXA2xxRTCState), + VMSTATE_UINT32(last_rdcr, PXA2xxRTCState), + VMSTATE_UINT32(last_rycr, PXA2xxRTCState), + VMSTATE_UINT32(last_swcr, PXA2xxRTCState), + VMSTATE_UINT32(last_rtcpicr, PXA2xxRTCState), + VMSTATE_INT64(last_hz, PXA2xxRTCState), + VMSTATE_INT64(last_sw, PXA2xxRTCState), + VMSTATE_INT64(last_pi, PXA2xxRTCState), + VMSTATE_END_OF_LIST(), + }, +}; + +static SysBusDeviceInfo pxa2xx_rtc_sysbus_info = { + .init = pxa2xx_rtc_init, + .qdev.name = "pxa2xx_rtc", + .qdev.desc = "PXA2xx RTC Controller", + .qdev.size = sizeof(PXA2xxRTCState), + .qdev.vmsd = &vmstate_pxa2xx_rtc_regs, +}; + /* I2C Interface */ typedef struct { i2c_slave i2c; @@ -2195,13 +2231,8 @@ PXA2xxState *pxa270_init(unsigned int sdram_size, const char *revision) s->pcmcia[0] = pxa2xx_pcmcia_init(0x20000000); s->pcmcia[1] = pxa2xx_pcmcia_init(0x30000000); - s->rtc_base = 0x40900000; - iomemtype = cpu_register_io_memory(pxa2xx_rtc_readfn, - pxa2xx_rtc_writefn, s, DEVICE_NATIVE_ENDIAN); - cpu_register_physical_memory(s->rtc_base, 0x1000, iomemtype); - pxa2xx_rtc_init(s); - register_savevm(NULL, "pxa2xx_rtc", 0, 0, pxa2xx_rtc_save, - pxa2xx_rtc_load, s); + sysbus_create_simple("pxa2xx_rtc", 0x40900000, + qdev_get_gpio_in(s->pic, PXA2XX_PIC_RTCALARM)); s->i2c[0] = pxa2xx_i2c_init(0x40301600, qdev_get_gpio_in(s->pic, PXA2XX_PIC_I2C), 0xffff); @@ -2341,13 +2372,8 @@ PXA2xxState *pxa255_init(unsigned int sdram_size) s->pcmcia[0] = pxa2xx_pcmcia_init(0x20000000); s->pcmcia[1] = pxa2xx_pcmcia_init(0x30000000); - s->rtc_base = 0x40900000; - iomemtype = cpu_register_io_memory(pxa2xx_rtc_readfn, - pxa2xx_rtc_writefn, s, DEVICE_NATIVE_ENDIAN); - cpu_register_physical_memory(s->rtc_base, 0x1000, iomemtype); - pxa2xx_rtc_init(s); - register_savevm(NULL, "pxa2xx_rtc", 0, 0, pxa2xx_rtc_save, - pxa2xx_rtc_load, s); + sysbus_create_simple("pxa2xx_rtc", 0x40900000, + qdev_get_gpio_in(s->pic, PXA2XX_PIC_RTCALARM)); s->i2c[0] = pxa2xx_i2c_init(0x40301600, qdev_get_gpio_in(s->pic, PXA2XX_PIC_I2C), 0xffff); @@ -2370,6 +2396,7 @@ static void pxa2xx_register_devices(void) i2c_register_slave(&pxa2xx_i2c_slave_info); sysbus_register_dev("pxa2xx-ssp", sizeof(PXA2xxSSPState), pxa2xx_ssp_init); sysbus_register_withprop(&pxa2xx_i2c_info); + sysbus_register_withprop(&pxa2xx_rtc_sysbus_info); } device_init(pxa2xx_register_devices)