From patchwork Thu Feb 10 11:18:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 82592 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 986F7B7109 for ; Thu, 10 Feb 2011 22:17:41 +1100 (EST) Received: from localhost ([127.0.0.1]:48073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnUWt-0001ts-Qz for incoming@patchwork.ozlabs.org; Thu, 10 Feb 2011 06:17:43 -0500 Received: from [140.186.70.92] (port=48414 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnUW4-0001rP-1O for qemu-devel@nongnu.org; Thu, 10 Feb 2011 06:16:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnUVx-0005S3-P8 for qemu-devel@nongnu.org; Thu, 10 Feb 2011 06:16:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnUVx-0005Rt-Bv for qemu-devel@nongnu.org; Thu, 10 Feb 2011 06:16:45 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1ABGhpt025457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Feb 2011 06:16:43 -0500 Received: from dhcp-5-188.str.redhat.com (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1ABGadH014556; Thu, 10 Feb 2011 06:16:42 -0500 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Thu, 10 Feb 2011 12:18:22 +0100 Message-Id: <1297336703-15632-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1297336703-15632-1-git-send-email-kwolf@redhat.com> References: <1297336703-15632-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, stefanha@gmail.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH v2 3/4] qed: Report error for unsupported features X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Instead of just returning -ENOTSUP, generate a more detailed error. Unfortunately we don't have a helpful text for features that we don't know yet, so just print the feature mask. It might be useful at least if someone asks for help. Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi --- block/qed.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/block/qed.c b/block/qed.c index 3273448..75ae244 100644 --- a/block/qed.c +++ b/block/qed.c @@ -14,6 +14,7 @@ #include "trace.h" #include "qed.h" +#include "qerror.h" static void qed_aio_cancel(BlockDriverAIOCB *blockacb) { @@ -311,7 +312,13 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags) return -EINVAL; } if (s->header.features & ~QED_FEATURE_MASK) { - return -ENOTSUP; /* image uses unsupported feature bits */ + /* image uses unsupported feature bits */ + char buf[64]; + snprintf(buf, sizeof(buf), "%" PRIx64, + s->header.features & ~QED_FEATURE_MASK); + qerror_report(QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, + bs->device_name, "QED", buf); + return -ENOTSUP; } if (!qed_is_cluster_size_valid(s->header.cluster_size)) { return -EINVAL;