From patchwork Mon Dec 20 21:13:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 76223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D2CA4B7088 for ; Tue, 21 Dec 2010 08:16:34 +1100 (EST) Received: from localhost ([127.0.0.1]:53051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUn5q-0001OB-CG for incoming@patchwork.ozlabs.org; Mon, 20 Dec 2010 16:16:30 -0500 Received: from [140.186.70.92] (port=48712 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PUn2u-0000BR-P9 for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:13:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PUn2t-0004nM-H0 for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:13:28 -0500 Received: from cantor.suse.de ([195.135.220.2]:52983 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PUn2t-0004n4-41 for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:13:27 -0500 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id BE27894A78; Mon, 20 Dec 2010 22:13:25 +0100 (CET) From: Alexander Graf To: qemu-devel Developers Date: Mon, 20 Dec 2010 22:13:24 +0100 Message-Id: <1292879604-22268-9-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1292879604-22268-1-git-send-email-agraf@suse.de> References: <1292879604-22268-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Kevin Wolf , Joerg Roedel , Gerd Hoffmann , Sebastian Herbszt Subject: [Qemu-devel] [PATCH 8/8] ahci: fix !msi interrupts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When not using MSI, receiving an interrupt while the interrupt line is active pulses the interrupt line. Without this, guests don't realize that a new interrupt occured. Signed-off-by: Alexander Graf --- hw/ide/ahci.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 97aef68..4c920da 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -153,11 +153,10 @@ static void ahci_check_irq(AHCIState *s) } } + ahci_irq_lower(s, NULL); if (s->control_regs.irqstatus && (s->control_regs.ghc & HOST_CTL_IRQ_EN)) { ahci_irq_raise(s, NULL); - } else { - ahci_irq_lower(s, NULL); } }