From patchwork Mon Dec 6 18:23:57 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 74432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6ACFBB70FE for ; Tue, 7 Dec 2010 05:32:57 +1100 (EST) Received: from localhost ([127.0.0.1]:56606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPfrq-0006zg-JW for incoming@patchwork.ozlabs.org; Mon, 06 Dec 2010 13:32:54 -0500 Received: from [140.186.70.92] (port=35900 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPfjo-00037R-OP for qemu-devel@nongnu.org; Mon, 06 Dec 2010 13:24:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPfjn-0004AO-Nx for qemu-devel@nongnu.org; Mon, 06 Dec 2010 13:24:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPfjn-0004AH-GY for qemu-devel@nongnu.org; Mon, 06 Dec 2010 13:24:35 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB6IOYBB012673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Dec 2010 13:24:34 -0500 Received: from localhost ([10.3.113.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oB6IOXn6030029; Mon, 6 Dec 2010 13:24:34 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Mon, 6 Dec 2010 16:23:57 -0200 Message-Id: <1291659852-23028-11-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1291659852-23028-1-git-send-email-lcapitulino@redhat.com> References: <1291659852-23028-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The new handler directly calls qmp_query_cpus() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino --- monitor.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.c index f067d07..2164853 100644 --- a/monitor.c +++ b/monitor.c @@ -931,13 +931,13 @@ static void print_cpu_iter(QObject *obj, void *opaque) monitor_printf(mon, "\n"); } -static void monitor_print_cpus(Monitor *mon, const QObject *data) +static void do_info_cpus(Monitor *mon) { - QList *cpu_list; + QObject *data; - assert(qobject_type(data) == QTYPE_QLIST); - cpu_list = qobject_to_qlist(data); - qlist_iter(cpu_list, print_cpu_iter, mon); + qmp_query_cpus(mon, &data); + qlist_iter(qobject_to_qlist(data), print_cpu_iter, mon); + qobject_decref(data); } static int do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data) @@ -2430,8 +2430,7 @@ static const mon_cmd_t info_cmds[] = { .args_type = "", .params = "", .help = "show infos for each CPU", - .user_print = monitor_print_cpus, - .mhandler.info_new = qmp_query_cpus, + .mhandler.info = do_info_cpus, }, { .name = "history",