From patchwork Tue Oct 12 13:00:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 67557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9135AB6EF0 for ; Wed, 13 Oct 2010 00:17:50 +1100 (EST) Received: from localhost ([127.0.0.1]:44782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5ejh-0006KI-UW for incoming@patchwork.ozlabs.org; Tue, 12 Oct 2010 09:17:46 -0400 Received: from [140.186.70.92] (port=40817 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5eTr-0007Ui-Vr for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5eTl-0004Vi-Cn for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:01:23 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:52643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5eTl-0004Mc-9o for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:01:17 -0400 Received: by mail-qw0-f45.google.com with SMTP id 5so1841033qwh.4 for ; Tue, 12 Oct 2010 06:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :message-id:x-mailer:in-reply-to:references; bh=DutKGmsFqba/9svMzkMMobhfjc3fuOvFf+EVN2AHHyU=; b=r319rzPGqkqBR0cuiWhXe31mdU2p4LO56gKxdVUUe9MG5FPj7kwb8KiVmx+oKoCs5h yPpCoVJ8cZvqytgqfhey56zY3j+j9+Gi5V5cPBTk/vCz6knBQj+u6v8q8SEdHfLv8YQS 4CDXHy+jvWdVGvWqeauFbzUfk7DhQ6Urq7E80= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; b=V9r0rXF0FTK/TPYEF88hwTPpGo9EwQBXu1d43q/08atebUYHII5k8GupepmhyFb6pt RCYLapcOmf8HeEskgX9cNVMxJoGLCArQkRtGz1OBwIo/rmarqUmmS8Jxn7VpcUK29a6Y 9iy9g8HSiulF7v5EQPhVozO4BU7A21Tpo94Jk= Received: by 10.224.194.138 with SMTP id dy10mr5725741qab.99.1286888476781; Tue, 12 Oct 2010 06:01:16 -0700 (PDT) Received: from localhost.localdomain (nat-pool-brq-t.redhat.com [209.132.186.34]) by mx.google.com with ESMTPS id s34sm5931078qcp.20.2010.10.12.06.01.14 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Oct 2010 06:01:15 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 12 Oct 2010 15:00:23 +0200 Message-Id: <1286888457-5033-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1286888457-5033-1-git-send-email-pbonzini@redhat.com> References: <1286888457-5033-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 05/39] test cc with the complete set of chosen flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The "test the C compiler works ok" comes before a bunch of flags are added for --cpu or just depending on the host. It helps debugging if the test is done after these flags are (unconditionally) added. Signed-off-by: Paolo Bonzini --- configure | 50 +++++++++++++++++++++++++------------------------- 1 files changed, 25 insertions(+), 25 deletions(-) diff --git a/configure b/configure index 6b5c323..8cd034a 100755 --- a/configure +++ b/configure @@ -217,31 +217,6 @@ QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS" QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS" LDFLAGS="-g $LDFLAGS" -gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits" -gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags" -gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags" -gcc_flags="-fstack-protector-all $gcc_flags" -cat > $TMPC << EOF -int main(void) { return 0; } -EOF -for flag in $gcc_flags; do - if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then - QEMU_CFLAGS="$flag $QEMU_CFLAGS" - fi -done - -# check that the C compiler works. -cat > $TMPC < $TMPC < $TMPC < $TMPC << EOF +int main(void) { return 0; } +EOF +for flag in $gcc_flags; do + if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then + QEMU_CFLAGS="$flag $QEMU_CFLAGS" + fi +done + # # Solaris specific configure tool chain decisions #