diff mbox

block/vvfat: Fix compiler warning in debug code

Message ID 1285874139-9740-1-git-send-email-weil@mail.berlios.de
State Accepted
Headers show

Commit Message

Stefan Weil Sept. 30, 2010, 7:15 p.m. UTC
Fix this compiler warning:
./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always true

Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 block/vvfat.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Blue Swirl Oct. 3, 2010, 7:50 a.m. UTC | #1
Thanks, applied.

On Thu, Sep 30, 2010 at 7:15 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Fix this compiler warning:
> ./block/vvfat.c:2285: error: comparison of unsigned expression >= 0 is always true
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  block/vvfat.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 53e57bf..26dd474 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2282,7 +2282,6 @@ static void check1(BDRVVVFATState* s)
>            fprintf(stderr, "deleted\n");
>            continue;
>        }
> -       assert(mapping->dir_index >= 0);
>        assert(mapping->dir_index < s->directory.next);
>        direntry_t* direntry = array_get(&(s->directory), mapping->dir_index);
>        assert(mapping->begin == begin_of_direntry(direntry) || mapping->first_mapping_index >= 0);
> --
> 1.7.1
>
>
diff mbox

Patch

diff --git a/block/vvfat.c b/block/vvfat.c
index 53e57bf..26dd474 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2282,7 +2282,6 @@  static void check1(BDRVVVFATState* s)
 	    fprintf(stderr, "deleted\n");
 	    continue;
 	}
-	assert(mapping->dir_index >= 0);
 	assert(mapping->dir_index < s->directory.next);
 	direntry_t* direntry = array_get(&(s->directory), mapping->dir_index);
 	assert(mapping->begin == begin_of_direntry(direntry) || mapping->first_mapping_index >= 0);