From patchwork Tue Jul 20 16:09:37 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jes Sorensen X-Patchwork-Id: 59343 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 20349B6F0E for ; Wed, 21 Jul 2010 02:31:42 +1000 (EST) Received: from localhost ([127.0.0.1]:41232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFik-0004aC-VV for incoming@patchwork.ozlabs.org; Tue, 20 Jul 2010 12:31:07 -0400 Received: from [140.186.70.92] (port=39657 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObFOU-0005tw-VQ for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObFO3-0006wc-2o for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:09:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30314) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObFO2-0006wQ-PC for qemu-devel@nongnu.org; Tue, 20 Jul 2010 12:09:43 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6KG9ff6009016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Jul 2010 12:09:41 -0400 Received: from localhost.localdomain ([10.3.121.4]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6KG9dUU024683; Tue, 20 Jul 2010 12:09:40 -0400 From: Jes.Sorensen@redhat.com To: qemu-devel@nongnu.org Date: Tue, 20 Jul 2010 18:09:37 +0200 Message-Id: <1279642177-21229-1-git-send-email-Jes.Sorensen@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jes Sorensen O_DIRECT (cache=none) requires sector alignment, however the physical sector size of CDROM/DVD drives is 2048, as opposed to most disk devices which use 512. QEMU is hard coding 512 all over the place, so allowing O_DIRECT for CDROM/DVD devices does not work. Exit with an error! Signed-off-by: Jes Sorensen --- block/raw-posix.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 291699f..1b840c4 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1139,6 +1139,11 @@ static int cdrom_open(BlockDriverState *bs, const char *filename, int flags) BDRVRawState *s = bs->opaque; s->type = FTYPE_CD; + if (flags & BDRV_O_NOCACHE) { + fprintf(stderr, "O_DIRECT (cache=none) for CDROM/DVD device (%s) " + "is unsupported\n", filename); + exit(1); + } /* open will not fail even if no CD is inserted, so add O_NONBLOCK */ return raw_open_common(bs, filename, flags, O_NONBLOCK);