Message ID | 1278419869-26126-2-git-send-email-armbru@redhat.com |
---|---|
State | New |
Headers | show |
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c6ef825..c6edcc2 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -552,6 +552,9 @@ static int virtio_blk_init_pci(PCIDevice *pci_dev) return -1; } vdev = virtio_blk_init(&pci_dev->qdev, &proxy->block); + if (!vdev) { + return -1; + } vdev->nvectors = proxy->nvectors; virtio_init_pci(proxy, vdev, PCI_VENDOR_ID_REDHAT_QUMRANET,
It can't actually fail now, but the next commit will change that. s390_virtio_blk_init() already checks for failure, but virtio_blk_init_pci() doesn't. Fix that. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- hw/virtio-pci.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)