diff mbox

[02/12] ide: Make it explicit that ide_create_drive() can't fail

Message ID 1277484812-22012-3-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster June 25, 2010, 4:53 p.m. UTC 
All callers of ide_create_drive() ignore its value.  Currently
harmless, because it fails only when qdev_init() fails, which fails
only when ide_drive_initfn() fails, which never fails.

Brittle.  Change it to die instead of silently ignoring failure.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ide/qdev.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig June 25, 2010, 7:40 p.m. UTC | #1 
On Fri, Jun 25, 2010 at 06:53:22PM +0200, Markus Armbruster wrote:
> All callers of ide_create_drive() ignore its value.  Currently
> harmless, because it fails only when qdev_init() fails, which fails
> only when ide_drive_initfn() fails, which never fails.
> 
> Brittle.  Change it to die instead of silently ignoring failure.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox

Patch

diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 0f9f22e..127478b 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -84,8 +84,7 @@  IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive)
     dev = qdev_create(&bus->qbus, "ide-drive");
     qdev_prop_set_uint32(dev, "unit", unit);
     qdev_prop_set_drive(dev, "drive", drive);
-    if (qdev_init(dev) < 0)
-        return NULL;
+    qdev_init_nofail(dev);
     return DO_UPCAST(IDEDevice, qdev, dev);
 }