From patchwork Thu Jun 3 16:48:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jes Sorensen X-Patchwork-Id: 54506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E06FEB7D1A for ; Fri, 4 Jun 2010 03:09:09 +1000 (EST) Received: from localhost ([127.0.0.1]:36316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKDuj-00087y-Rm for incoming@patchwork.ozlabs.org; Thu, 03 Jun 2010 13:09:05 -0400 Received: from [140.186.70.92] (port=59638 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKDaz-0002id-TO for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKDay-00069F-Pj for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4823) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKDay-000695-J3 for qemu-devel@nongnu.org; Thu, 03 Jun 2010 12:48:40 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o53Gmcnu020292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Jun 2010 12:48:38 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o53GmE8n028747; Thu, 3 Jun 2010 12:48:36 -0400 From: Jes.Sorensen@redhat.com To: anthony@codemonkey.ws Date: Thu, 3 Jun 2010 18:48:08 +0200 Message-Id: <1275583692-11678-13-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> References: <1275583692-11678-1-git-send-email-Jes.Sorensen@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Jes Sorensen , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 12/16] Move chroot handling to OS specific files. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jes Sorensen Move chroot handling to OS specific files. Signed-off-by: Jes Sorensen --- os-posix.c | 19 +++++++++++++++++++ qemu-os-posix.h | 1 + qemu-os-win32.h | 1 + vl.c | 18 +----------------- 4 files changed, 22 insertions(+), 17 deletions(-) diff --git a/os-posix.c b/os-posix.c index f8a092e..a91e1f6 100644 --- a/os-posix.c +++ b/os-posix.c @@ -37,6 +37,7 @@ #include "net/slirp.h" static struct passwd *user_pwd; +static const char *chroot_dir; void os_setup_early_signal_handling(void) { @@ -169,6 +170,9 @@ int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) exit(1); } break; + case QEMU_OPTION_chroot: + chroot_dir = optarg; + break; default: ret = -1; } @@ -192,3 +196,18 @@ void os_change_process_uid(void) } } } + +void os_change_root(void) +{ + if (chroot_dir) { + if (chroot(chroot_dir) < 0) { + fprintf(stderr, "chroot failed\n"); + exit(1); + } + if (chdir("/")) { + perror("not able to chdir to /"); + exit(1); + } + } + +} diff --git a/qemu-os-posix.h b/qemu-os-posix.h index 6d8cf79..91c7b68 100644 --- a/qemu-os-posix.h +++ b/qemu-os-posix.h @@ -32,5 +32,6 @@ static inline void os_host_main_loop_wait(int *timeout) void os_setup_signal_handling(void); void os_change_process_uid(void); +void os_change_root(void); #endif diff --git a/qemu-os-win32.h b/qemu-os-win32.h index 9df0eda..245b188 100644 --- a/qemu-os-win32.h +++ b/qemu-os-win32.h @@ -44,5 +44,6 @@ void os_host_main_loop_wait(int *timeout); static inline void os_setup_signal_handling(void) {}; static inline void os_change_process_uid(void) {}; +static inline void os_change_root(void) {}; #endif diff --git a/vl.c b/vl.c index d42be8d..7173684 100644 --- a/vl.c +++ b/vl.c @@ -2311,7 +2311,6 @@ int main(int argc, char **argv, char **envp) const char *incoming = NULL; #ifndef _WIN32 int fd = 0; - const char *chroot_dir = NULL; #endif int show_vnc_port = 0; int defconfig = 1; @@ -3055,11 +3054,6 @@ int main(int argc, char **argv, char **envp) default_cdrom = 0; default_sdcard = 0; break; -#ifndef _WIN32 - case QEMU_OPTION_chroot: - chroot_dir = optarg; - break; -#endif case QEMU_OPTION_xen_domid: if (!(xen_available())) { printf("Option %s not supported for this target\n", popt->name); @@ -3548,17 +3542,7 @@ int main(int argc, char **argv, char **envp) exit(1); } - if (chroot_dir) { - if (chroot(chroot_dir) < 0) { - fprintf(stderr, "chroot failed\n"); - exit(1); - } - if (chdir("/")) { - perror("not able to chdir to /"); - exit(1); - } - } - + os_change_root(); os_change_process_uid(); if (daemonize) {