From patchwork Sun May 30 22:35:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artyom Tarasenko X-Patchwork-Id: 54007 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B683DB7D2F for ; Mon, 31 May 2010 08:58:44 +1000 (EST) Received: from localhost ([127.0.0.1]:55655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIr8K-0004DA-LZ for incoming@patchwork.ozlabs.org; Sun, 30 May 2010 18:37:28 -0400 Received: from [140.186.70.92] (port=44184 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIr73-0002z6-61 for qemu-devel@nongnu.org; Sun, 30 May 2010 18:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OIr6k-0000FL-0q for qemu-devel@nongnu.org; Sun, 30 May 2010 18:35:51 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:35564) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIr6j-0000FD-Qw for qemu-devel@nongnu.org; Sun, 30 May 2010 18:35:49 -0400 Received: by fg-out-1718.google.com with SMTP id 16so913741fgg.10 for ; Sun, 30 May 2010 15:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=XuF1fgTNZdU053X6JGx0TAavyzwSeTl4QaAouKqbDTk=; b=qp920Fh+uHQ2fbuSSgyDApVdEtIfN55FTgM9LzJ652556I6kyT12sgBDYl9uOlxzb9 3cung3BfHKpX4bSbkepz/kcBTCSvDuFHtN3TzAyiNR7iViVOFF8VtV0gTXgk+5cXhxAh TJF6skqEAh8p+zagA0IZN8RBU+ILY1TH/RkM8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=N05IMq0eNjFpmH6fMgPHiJYyFbEWVRW/d+PRb8/4O+EztY+rWQ3HXvvriKoJm7Md2G BMvos8+2SEjcr6gdpS74S0NFuf9NTcQpeUk8Oo6+CnsXFJy9YqiTmzZmFQpO3htu15rG dfNRah4jS05VqJokMnRu9cpy9Qg9Q230ScilY= Received: by 10.86.6.16 with SMTP id 16mr7406531fgf.55.1275258947909; Sun, 30 May 2010 15:35:47 -0700 (PDT) Received: from localhost (g231066161.adsl.alicedsl.de [92.231.66.161]) by mx.google.com with ESMTPS id p17sm7023935fka.16.2010.05.30.15.35.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 30 May 2010 15:35:47 -0700 (PDT) From: Artyom Tarasenko To: qemu-devel@nongnu.org Date: Mon, 31 May 2010 00:35:46 +0200 Message-Id: <1275258946-15739-1-git-send-email-atar4qemu@gmail.com> X-Mailer: git-send-email 1.6.2.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: blauwirbel@gmail.com, Artyom Tarasenko Subject: [Qemu-devel] [PATCH] sparc32 esp fix spurious interrupts in chip reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org lower interrupt during chip reset. Otherwise the ESP_RSTAT register may get out of sync with the IRQ line status. This effect became visible after commit 65899fe3 Signed-off-by: Artyom Tarasenko --- hw/esp.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 0a8cf6e..0532c67 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -423,6 +423,7 @@ static void esp_reset(DeviceState *d) { ESPState *s = container_of(d, ESPState, busdev.qdev); + esp_lower_irq(s); memset(s->rregs, 0, ESP_REGS); memset(s->wregs, 0, ESP_REGS); s->rregs[ESP_TCHI] = TCHI_FAS100A; // Indicate fas100a