From patchwork Mon May 10 02:32:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Palatin X-Patchwork-Id: 52087 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6A4BCB7D49 for ; Tue, 11 May 2010 00:07:50 +1000 (EST) Received: from localhost ([127.0.0.1]:59492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBTe6-0002hH-UG for incoming@patchwork.ozlabs.org; Mon, 10 May 2010 10:07:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OBIn9-0001iA-5e for qemu-devel@nongnu.org; Sun, 09 May 2010 22:32:23 -0400 Received: from [140.186.70.92] (port=45605 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBIn4-0001hp-82 for qemu-devel@nongnu.org; Sun, 09 May 2010 22:32:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBImx-0002Ot-9E for qemu-devel@nongnu.org; Sun, 09 May 2010 22:32:18 -0400 Received: from izumi-v2.palats.com ([91.121.80.203]:58763 helo=izumi.palats.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBImx-0002OZ-40 for qemu-devel@nongnu.org; Sun, 09 May 2010 22:32:11 -0400 Received: by izumi.palats.com (Postfix, from userid 1000) id F07F81AA864C; Mon, 10 May 2010 04:32:08 +0200 (CEST) From: Vincent Palatin To: qemu-devel@nongnu.org Date: Mon, 10 May 2010 04:32:07 +0200 Message-Id: <1273458728-24918-2-git-send-email-vincent.palatin_qemu@m4x.org> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1273458728-24918-1-git-send-email-vincent.palatin_qemu@m4x.org> References: <1273458728-24918-1-git-send-email-vincent.palatin_qemu@m4x.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Mon, 10 May 2010 09:56:04 -0400 Cc: Vincent Palatin , Jan Kiszka , David Ahern Subject: [Qemu-devel] [PATCH 1/2] ehci: Fix error detection when registering a new list base address X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We must check against the current running command not the list address. Signed-off-by: Vincent Palatin --- hw/usb-ehci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 8be0780..e724653 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -774,7 +774,7 @@ static void ehci_mem_writel(void *ptr, target_phys_addr_t addr, uint32_t val) break; case PERIODICLISTBASE: - if (val & USBCMD_PSE) { + if (s->usbcmd & USBCMD_PSE) { fprintf(stderr, "Guest OS should not be setting the periodic" " list base register while periodic schedule is enabled\n"); return; @@ -783,7 +783,7 @@ static void ehci_mem_writel(void *ptr, target_phys_addr_t addr, uint32_t val) break; case ASYNCLISTADDR: - if (val & USBCMD_ASE) { + if (s->usbcmd & USBCMD_ASE) { fprintf(stderr, "Guest OS should not be setting the async list" " address register while async schedule is enabled\n"); return;