From patchwork Wed Apr 14 05:28:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 50103 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E4635B7D1B for ; Wed, 14 Apr 2010 15:46:45 +1000 (EST) Received: from localhost ([127.0.0.1]:36685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1vQw-0004hs-PI for incoming@patchwork.ozlabs.org; Wed, 14 Apr 2010 01:46:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1vBb-0002GI-2r for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:51 -0400 Received: from [140.186.70.92] (port=49020 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1vBZ-0002Fh-EQ for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1vBX-0005zn-RC for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21011) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1vBX-0005zi-I8 for qemu-devel@nongnu.org; Wed, 14 Apr 2010 01:30:47 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3E5UkH8019464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 Apr 2010 01:30:46 -0400 Received: from localhost (vpn-236-230.phx2.redhat.com [10.3.236.230]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3E5Uiv5003847; Wed, 14 Apr 2010 01:30:45 -0400 From: Amit Shah To: Anthony Liguori Date: Wed, 14 Apr 2010 10:58:27 +0530 Message-Id: <1271222917-7803-8-git-send-email-amit.shah@redhat.com> In-Reply-To: <1271222917-7803-7-git-send-email-amit.shah@redhat.com> References: <1271222917-7803-1-git-send-email-amit.shah@redhat.com> <1271222917-7803-2-git-send-email-amit.shah@redhat.com> <1271222917-7803-3-git-send-email-amit.shah@redhat.com> <1271222917-7803-4-git-send-email-amit.shah@redhat.com> <1271222917-7803-5-git-send-email-amit.shah@redhat.com> <1271222917-7803-6-git-send-email-amit.shah@redhat.com> <1271222917-7803-7-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu list , Amit Shah , Gerd Hoffmann , Juan Quintela Subject: [Qemu-devel] [PATCH v5 07/17] virtio-serial: Remove redundant check for 0-sized write request X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The check for a 0-sized write request to a guest port is not necessary; the while loop below won't be executed in this case and all will be fine. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 8efba0b..c1d9851 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -91,9 +91,6 @@ static size_t write_to_port(VirtIOSerialPort *port, if (!virtio_queue_ready(vq)) { return 0; } - if (!size) { - return 0; - } while (offset < size) { int i;